dd-firmware / firmware / App

Monitors

Clone Tools

Stats

Commits this week: 11
Total Committers: 14
Last Commit: 31 Dec 69
Commits this week: 11

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 30 Mar
2:47 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2008_Dialysate Composition - DD - 04: DEV - Feature Implementation
LEAHI-DD-FIRMWARE-LDT-2008_Dialysate Composition - DD - 04: DEV - Feature Implementation
10:17 am

Dara Navaei

10:15 am

Vendor - TEL - Varshini Nagabooshanam and Vendor - TEL - Jashwant Gantyada

10:15 am

Vendor - TEL - Varshini Nagabooshanam

10:15 am

Sean Nash

Remove extra blank lines.

Remove extra blank lines.

10:14 am

Sean Nash

This "s" looks out of place.

This "s" looks out of place.

10:14 am

Sean Nash

But this is a f/w shared unit (so both TD and DD f/w include this unit in their build) and we may add a case later. Because it's a common unit, we should design it to work for both f/w builds.

But this is a f/w shared unit (so both TD and DD f/w include this unit in their build) and we may add a case later. Because it's a common unit, we should design it to work for both f/w builds.

Friday 27 Mar
7:56 am

Vendor - TEL - Sameer Poyil

No, its deleted

No, its deleted

7:54 am

Vendor - TEL - Sameer Poyil

I do not see TD use case in any of the PI controller functions. so do we need TD here ?

I do not see TD use case in any of the PI controller functions. so do we need TD here ?

Wednesday 25 Mar
4:01 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
Tuesday 24 Mar
2:31 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
Thursday 19 Mar
3:47 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
11:16 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3777_Sprint 25 fixes.
LEAHI-DD-FIRMWARE-LDT-3777_Sprint 25 fixes.
9:01 am

Sean Nash

Why do we have a local sub state variable that we don't do anything with?

Why do we have a local sub state variable that we don't do anything with?

Wednesday 18 Mar
8:29 pm

Vendor - TEL - Sameer Poyil

This is to avoid compilation warning

This is to avoid compilation warning

3:37 pm

Dara Navaei

1:05 pm

Sean Nash

I don't think these coefficient access functions need to be public. Consider making them private.

I don't think these coefficient access functions need to be public. Consider making them private.

1:03 pm

Sean Nash

These seem more like concentrate doses, not dialysate doses. Consider renaming.

These seem more like concentrate doses, not dialysate doses. Consider renaming.

1:02 pm

Sean Nash

What is this?

What is this?

1:01 pm

Sean Nash

Add blank line after declarations.

Add blank line after declarations.

1:00 pm

Sean Nash

Are these coming back? If so, add TODO comment to restore later. If not, delete them.

Are these coming back? If so, add TODO comment to restore later. If not, delete them.

12:56 pm

Sean Nash

else TD ?

else TD ?

12:55 pm

Sean Nash

This is a structure, not an enumeration.

This is a structure, not an enumeration.

Tuesday 17 Mar
2:46 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3750_DD_Staging_Rebase
LEAHI-DD-FIRMWARE-LDT-3750_DD_Staging_Rebase
Monday 16 Mar
11:10 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
LEAHI-DD-FIRMWARE-LDT-2004_Dialysate Composition - DD
9:52 am

Sean Nash

9:50 am

Michael Garthwaite

Friday 13 Mar
9:33 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:31 am

Sean Nash

Should we create a structure for these moving average filters and make an array of them based on enum of temp sensors? It looks kind of messy having separate handling for each sensor - can we conso...

Should we create a structure for these moving average filters and make an array of them based on enum of temp sensors?
It looks kind of messy having separate handling for each sensor - can we consolidate some of this code?

9:28 am

Sean Nash

Should we maybe just have a constant array of sample counts based on enum of temp sensors?

Should we maybe just have a constant array of sample counts based on enum of temp sensors?