dd-firmware / firmware / App / Controllers

ROPump.c

Clone Tools

Stats

Commits this week: 5
Total Committers: 4
Last Commit: 30 Jul 24
Commits this week: 5

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 11 Dec
11:32 am

Sean Nash

Add space before ).

Add space before ).

11:32 am

Sean Nash

Add space between if and (.

Add space between if and (.

11:31 am

Sean Nash

Be consistent on whether you have a blank line between break and next case.

Be consistent on whether you have a blank line between break and next case.

11:30 am

Sean Nash

Keep blank line here.

Keep blank line here.

11:12 am

Sean Nash

What are these coefficients for? At least describe in comments, if not the names.

What are these coefficients for? At least describe in comments, if not the names.

11:10 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

8:23 am

Raghu Kallala

Add a 1 second persistence on this alarm

Add a 1 second persistence on this alarm

7:26 am

Raghu Kallala

Handle transition here after changing the flush logic transitionToGenPermeateDefeaturedMode(); requestGenWaterDefStart();

Handle transition here after changing the flush logic

transitionToGenPermeateDefeaturedMode();
requestGenWaterDefStart();

7:24 am

Raghu Kallala

Need to remove this handler

Need to remove this handler

7:22 am

Raghu Kallala

Add blank line before return statement

Add blank line before return statement

7:21 am

Raghu Kallala

Remove handlePreGenPDefInletWaterState

Remove handlePreGenPDefInletWaterState

7:20 am

Raghu Kallala

Update FP_Pre_GenP_Def_Mode_States enum in FPDefs.h

Update FP_Pre_GenP_Def_Mode_States enum in FPDefs.h

7:19 am

Raghu Kallala

Call this in both Pre Gen: Verify Water and Gen Permeate

Call this in both Pre Gen: Verify Water and Gen Permeate

7:17 am

Raghu Kallala

Greater than or equal to for low limit pressureP13 >= MAX_INLET_RO_PUMP_PRESSURE_WARNING_LOW_PSIG Also give space before and after parentheses.

Greater than or equal to for low limit
pressureP13 >= MAX_INLET_RO_PUMP_PRESSURE_WARNING_LOW_PSIG

Also give space before and after parentheses.

7:15 am

Raghu Kallala

Put quadratic and linear terms in parentheses.

Put quadratic and linear terms in parentheses.

6:56 am

Vendor - TEL - Varshini Nagabooshanam and Sean Nash

Tuesday 09 Dec
2:18 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2185_(IO, FP) Water Treatment and Degassing IOFP Alpha Refinement Updates
LEAHI-DD-FIRMWARE-LDT-2185_(IO, FP) Water Treatment and Degassing IOFP Alpha Refinement Updates
11:25 am

Raghu Kallala

10:43 am

Sean Nash , Vinayakam Mani and Michael Garthwaite

10:29 am

Raghu Kallala

Resolved

Resolved

10:16 am

Sean Nash

Change comment from 3 to 5 minutes to match code.

Change comment from 3 to 5 minutes to match code.

10:14 am

Sean Nash

I don't see fix

I don't see fix

10:03 am

Raghu Kallala

Fixed the ordering

Fixed the ordering

Friday 05 Dec
3:01 pm

Sean Nash

I'm confused as to why the available alarm that this alarm replaced is in a different row within this table. That seems wrong.

I'm confused as to why the available alarm that this alarm replaced is in a different row within this table. That seems wrong.

Thursday 04 Dec
10:18 am

Raghu Kallala

Handled in FPOperationModes and respective states of PreGen have it.

Handled in FPOperationModes and respective states of PreGen have it.

10:17 am

Raghu Kallala

Checked with Eliza if they need it for alarm persistence time. Not needed at this time, we can add them in future

Checked with Eliza if they need it for alarm persistence time. Not needed at this time, we can add them in future

10:15 am

Raghu Kallala

Fixed. Thanks

Fixed. Thanks

10:14 am

Raghu Kallala

Fixed.

Fixed.

10:11 am

Raghu Kallala

Fixed.

Fixed.

10:10 am

Raghu Kallala

Fixed. thanks

Fixed. thanks