dd-firmware / firmware / App / Controllers

BalancingChamber.h

Clone Tools

Stats

Commits this week: 0
Total Committers: 2
Last Commit: 18 Dec
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 05 Dec
1:26 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -3
    • +3
    ./BalancingChamber.h
  2. … 121 more files in changeset.
Friday 10 Oct
3:55 pm

Vinayakam Mani

Tuesday 07 Oct
2:15 pm

jpaguio  (deleted user)

2:15 pm

jpaguio  (deleted user)

LDT-2198 was merged into this branch after being merged into staging_alpha. Branch will be killed and relevant code changes were reviewed appropriately.

LDT-2198 was merged into this branch after being merged into staging_alpha. Branch will be killed and relevant code changes were reviewed appropriately.

9:48 am

Sean Nash

9:46 am

Sean Nash

Monday 06 Oct
12:53 pm

Raghu Kallala

12:49 pm

Vinayakam Mani

Done.

Done.

11:45 am

Raghu Kallala

Align comments in all of this switch cases

Align comments in all of this switch cases

11:01 am

Sean Nash and Vinayakam Mani

11:00 am

Raghu Kallala , Michael Garthwaite and Vinayakam Mani

Friday 03 Oct
2:45 pm

Vinayakam Mani

Done.

Done.

2:16 pm

Vinayakam Mani

LDT-2198 pressure limits update

Options
    • -4
    • +4
    ./BalancingChamber.h
  2. … 2 more files in changeset.
Tuesday 30 Sep
1:33 pm

Vinayakam Mani

RESOLVED IN CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

11:45 am

jpaguio  (deleted user)

Done

Done

11:45 am

jpaguio  (deleted user)

Done

Done

11:45 am

jpaguio  (deleted user)

Done

Done

11:44 am

jpaguio  (deleted user)

Done

Done

11:44 am

jpaguio  (deleted user)

Done

Done

9:45 am

Sean Nash

Appears to be dialysate to dialyzer flow rate.

Appears to be dialysate to dialyzer flow rate.

9:44 am

Sean Nash

Looking at the implementation of this function, it appears that this function is setting dialysateFlowRate to target rate only when delivering dialysate to the dialyzer and to zero in all other cas...

Looking at the implementation of this function, it appears that this function is setting dialysateFlowRate to target rate only when delivering dialysate to the dialyzer and to zero in all other cases. Consider changing variable name to something like dialysateToDialyzerFlowRate and updating function description in header to make this more clear.

9:39 am

Sean Nash

0.0F.

0.0F.

9:21 am

Vinayakam Mani

Check the current Gen dialysate sub state.

Check the current Gen dialysate sub state.

9:20 am

Vinayakam Mani

Please use 0.0F (since its float variable).

Please use 0.0F (since its float variable).

Friday 26 Sep
10:04 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-1196_DD: Request for a variable for target Qd rate
LEAHI-DD-FIRMWARE-LDT-1196_DD: Request for a variable for target Qd rate
Thursday 25 Sep
8:48 am

Sean Nash

Why the extra leading zeroes? If you want to ensure the literal is treated like a U32, you can do 0x00000001 or simply 1U, but I suspect the compiler will default to 32 bits anyway.

Why the extra leading zeroes? If you want to ensure the literal is treated like a U32, you can do 0x00000001 or simply 1U, but I suspect the compiler will default to 32 bits anyway.

Wednesday 24 Sep
9:10 am

Sean Nash

I believe baro is being moved to the TD firmware. DD will have to get baro readings from TD broadcasts.

I believe baro is being moved to the TD firmware. DD will have to get baro readings from TD broadcasts.

Tuesday 23 Sep
10:23 am

jpaguio  (deleted user)

Do you want to add a space for the baro pressure sensor from which we receive from the TD?

Do you want to add a space for the baro pressure sensor from which we receive from the TD?

Monday 22 Sep
4:00 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-2138_Update DD FW to actuate D80 valve (connected to D54) during dialysate generation or when bicarb pump running
LEAHI-DD-FIRMWARE-LDT-2138_Update DD FW to actuate D80 valve (connected to D54) during dialysate generation or when bicarb pump running
Thursday 18 Sep
9:38 am

Vinayakam Mani

I have removed multiple M4 valve control across in DD. IO/FP will govern the M4 valve control.

I have removed multiple M4 valve control across in DD. IO/FP will govern the M4 valve control.