Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Space after if.

Space after if.

Can we bring depressurize as well one of the states like fill, supply and drain? And the same way when one of the operations initiated and other should not kick in.

Can we bring depressurize as well one of the states like fill, supply and drain? And the same way when one of the operations initiated and other should not kick in.

remove empty space after d66pressure variable. or match the indent to previous statement.

remove empty space after d66pressure variable. or match the indent to previous statement.

Add a TODO comment (remove later): this should be handled in IO/FP module.

Add a TODO comment (remove later): this should be handled in IO/FP module.

Update comment.

Update comment.

Add comment.

Add comment.

Depressurize?

Depressurize?

Fix the typo.

Fix the typo.

moved to general task

moved to general task

We need to keep D64 opened after supply to maintain the supply to bicarb green flow filter

We need to keep D64 opened after supply to maintain the supply to bicarb green flow filter

LEAHI-DD-FIRMWARE-LDT-4409_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 3/1:
LEAHI-DD-FIRMWARE-LDT-4409_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 3/1:
Can we move this exec at task level, independent of Drybicart operations?

Can we move this exec at task level, independent of Drybicart operations?

Comment missing?

Comment missing?

Looks On event handled later. One event should be fine for On condtion.

Looks On event handled later. One event should be fine for On condtion.

Space after 0

Space after 0

prevDryBicartState

prevDryBicartState

I guess, you should use OnOff status as second argument, since isBalChamberSwitchingActive varirable set after this function, it won't have latest status.

I guess, you should use OnOff status as second argument, since isBalChamberSwitchingActive varirable set after this function, it won't have latest status.

prevBalChamberState?

prevBalChamberState?

Should we also send an event when we start the heater?

Should we also send an event when we start the heater?

We can combine all these condition checks in a single if() at line 423 separated by || and then we can send the event change in one line. The code will still work if we remove the first condition c...

We can combine all these condition checks in a single if() at line 423 separated by || and then we can send the event change in one line.
The code will still work if we remove the first condition check for prevState from line 427 and 431

LEAHI-DD-FIRMWARE-LDT-4612_Dialysate Composition (Dry Bicarbonate) - FW Iteration - 4/1:
LEAHI-DD-FIRMWARE-LDT-4612_Dialysate Composition (Dry Bicarbonate) - FW Iteration - 4/1:
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 12 more files in changeset.
Michaels latest code resolved this issue. make sure when you merge to staging, pull the latest from staging. Check with Michael on code commit in staging.

Michaels latest code resolved this issue. make sure when you merge to staging, pull the latest from staging. Check with Michael on code commit in staging.

LDT-4409 addressed review comments

  1. … 5 more files in changeset.
I will mark it as TODO , so you can close it

I will mark it as TODO , so you can close it

Update name.

Update name.