leahi-dialin / leahi_dialin

td

Clone Tools

Stats

Commits this week: 12
Total Committers: 10
Last Commit: 25 Jun
Commits this week: 12

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 26 Jun
4:56 pm

Raghu Kallala and Michael Garthwaite

4:21 pm

Zoltan Miskolci

fixed

fixed

2:13 pm

Raghu Kallala

fix typo

fix typo

1:43 pm

Michael Garthwaite

Thursday 25 Jun
5:33 pm

Behrouz NematiPour

I am happy to see that this old code is improving. I would recommend using the Conversion module instead of strings and DataTypes, as it handles everything automatically. Examples can be found in t...

I am happy to see that this old code is improving.
I would recommend using the Conversion module instead of strings and DataTypes, as it handles everything automatically.
Examples can be found in the following file in this CR:
https://devapps.diality.us/cru/#LEAHI-DIALIN-LDT-4484-1CFR-84688

5:19 pm

Behrouz NematiPour

Please add a docstring for the function. including the intention and parameters with their intentions.

Please add a docstring for the function.
including the intention and parameters with their intentions.

5:17 pm

Behrouz NematiPour

Same for CanChannels. The Channels we are referring to here are Leahi's or Denali's. Channels mainly have no meaning beyond their priorities when a collision occurs.

Same for CanChannels.
The Channels we are referring to here are Leahi's or Denali's.
Channels mainly have no meaning beyond their priorities when a collision occurs.

5:15 pm

Behrouz NematiPour

I recommend DenaliMessage or LeahiMessage, as CanMessage is generic, whereas Leahi/Denali indicate that the protocol is also implemented in the message we are sending. I'm not sure why the name was...

I recommend DenaliMessage or LeahiMessage, as CanMessage is generic, whereas Leahi/Denali indicate that the protocol is also implemented in the message we are sending.
I'm not sure why the name was changed, as it is a lot of change.
Also, there is no CAN Message.
There is a CAN Frame and a Leahi/Denali Message.

4:32 pm

Dara Navaei

LEAHI-DIALIN-LDT-4072_Power Loss - FW Implementation - 2/3:
LEAHI-DIALIN-LDT-4072_Power Loss - FW Implementation - 2/3:
Tuesday 23 Jun
10:40 am

Zoltan Miskolci

updated

updated

10:32 am

Raghu Kallala

Remove extra spaces before comment

Remove extra spaces before comment

Monday 22 Jun
2:55 pm

Zoltan Miskolci

1:00 pm

Vinayakam Mani and Michael Garthwaite

Thursday 18 Jun
4:34 pm

Zoltan Miskolci

Please consult the FW-SW integration xls file for MSG_ID reservations. Please add the ones you need to that list as without missing any reservations for IDs the randomly added IDs will be overwritt...

Please consult the FW-SW integration xls file for MSG_ID reservations.
Please add the ones you need to that list as without missing any reservations for IDs the randomly added IDs will be overwritten by reserved ones.

9:40 am

Michael Garthwaite

Instead of removing, could you move them to the bottom of the list to prevent exceptions being thrown?

Instead of removing, could you move them to the bottom of the list to prevent exceptions being thrown?

9:17 am

Dara Navaei

LEAHI-DIALIN-LDT-4732_(Dialin) Dialin version should be included in the all system logs
LEAHI-DIALIN-LDT-4732_(Dialin) Dialin version should be included in the all system logs
Wednesday 17 Jun
2:25 pm

Zoltan Miskolci

Updated msg IDs Updated version handling

Options
    • -10
    • +14
    ./treatment_delivery.py
  2. … 3 more files in changeset.
Tuesday 16 Jun
9:53 am

Zoltan Miskolci

Monday 15 Jun
3:32 pm

Dara Navaei

LEAHI-DIALIN-LDT-4160_[Request] Get function for full detailed Alarm Table
LEAHI-DIALIN-LDT-4160_[Request] Get function for full detailed Alarm Table
2:35 pm

Raghu Kallala and Michael Garthwaite

1:52 pm

Zoltan Miskolci

event fix

Options
    • -1
    • +1
    ./modules/events.py
  2. … 2 more files in changeset.
1:50 pm

Zoltan Miskolci

Fixed non working modules

Options
    • -6
    • +5
    ./modules/pressure_sensors.py
    • -38
    • +1
    ./modules/syringe_pump.py
  3. … 1 more file in changeset.
Friday 12 Jun
9:16 am

Dara Navaei

LEAHI-DIALIN-LDT-4721_Add extra parameter to start pregen request
LEAHI-DIALIN-LDT-4721_Add extra parameter to start pregen request
Thursday 11 Jun
1:30 pm

Sean Nash

1:30 pm

Sean Nash

Monday 08 Jun
11:20 am

Dara Navaei

LEAHI-DIALIN-LDT-4484_[Dialin] Create Dry Self Test module in dialin
LEAHI-DIALIN-LDT-4484_[Dialin] Create Dry Self Test module in dialin
Wednesday 03 Jun
5:02 pm

Dara Navaei

LEAHI-DIALIN-LDT-3735_System Data and Logs - DD - Non-Volatile Memory - 04: DEV - Feature Implementation
LEAHI-DIALIN-LDT-3735_System Data and Logs - DD - Non-Volatile Memory - 04: DEV - Feature Implementation
Monday 01 Jun
4:20 pm

Zoltan Miskolci

4:00 pm

Zoltan Miskolci

Merge branch 'LDT-3904-opmode-the-operation-mode-broad' into staging

Options
    • -22
    • +41
    ./modules/syringe_pump.py
    • -66
    • +39
    ./modules/valves.py
    • -83
    • +72
    ./treatment_delivery.py
  4. … 10 more files in changeset.
8:01 am

Raghu Kallala