Activity leahi-dialin/leahi_dialin/td/modules

Tree
Accordion

Stats

Commits this week: 8

Total Committers:	9
Last Commit:	25 Jun
Commits this week:	8

Lines of code count not available

Commit Activity

last updated a few minutes ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Thursday 25 Jun

5:33 pm

Behrouz NematiPour

More
Re: LEAHI-DIALIN-LDT-4484-1
commented on review

I am happy to see that this old code is improving. I would recommend using the Conversion module instead of strings and DataTypes, as it handles everything automatically. Examples can be found in t...

I am happy to see that this old code is improving.
I would recommend using the Conversion module instead of strings and DataTypes, as it handles everything automatically.
Examples can be found in the following file in this CR:
https://devapps.diality.us/cru/#LEAHI-DIALIN-LDT-4484-1CFR-84688

5:19 pm

Behrouz NematiPour

More
Re: LEAHI-DIALIN-LDT-4484-1
commented on review

Please add a docstring for the function. including the intention and parameters with their intentions.

Please add a docstring for the function.
including the intention and parameters with their intentions.

5:17 pm

Behrouz NematiPour

More
Re: LEAHI-DIALIN-LDT-4484-1
commented on review

Same for CanChannels. The Channels we are referring to here are Leahi's or Denali's. Channels mainly have no meaning beyond their priorities when a collision occurs.

Same for CanChannels.
The Channels we are referring to here are Leahi's or Denali's.
Channels mainly have no meaning beyond their priorities when a collision occurs.

5:15 pm

Behrouz NematiPour

More
Re: LEAHI-DIALIN-LDT-4484-1
commented on review

I recommend DenaliMessage or LeahiMessage, as CanMessage is generic, whereas Leahi/Denali indicate that the protocol is also implemented in the message we are sending. I'm not sure why the name was...

I recommend DenaliMessage or LeahiMessage, as CanMessage is generic, whereas Leahi/Denali indicate that the protocol is also implemented in the message we are sending.
I'm not sure why the name was changed, as it is a lot of change.
Also, there is no CAN Message.
There is a CAN Frame and a Leahi/Denali Message.

4:32 pm

Dara Navaei

More
LEAHI-DIALIN-LDT-4072-1
started review

LEAHI-DIALIN-LDT-4072_Power Loss - FW Implementation - 2/3:

LEAHI-DIALIN-LDT-4072_Power Loss - FW Implementation - 2/3:

Tuesday 23 Jun

10:40 am

Zoltan Miskolci

updated

updated

10:32 am

Raghu Kallala

More
Re: LEAHI-DIALIN-LDT-4484-1
commented on review

Remove extra spaces before comment

Remove extra spaces before comment

Tuesday 16 Jun

9:53 am

Zoltan Miskolci

Monday 15 Jun

3:32 pm

Dara Navaei

More
LEAHI-DIALIN-LDT-4160-1
started review

LEAHI-DIALIN-LDT-4160_[Request] Get function for full detailed Alarm Table

LEAHI-DIALIN-LDT-4160_[Request] Get function for full detailed Alarm Table

2:35 pm

Raghu Kallala and Michael Garthwaite

More
LEAHI-DIALIN-LDT-4721-1
finished reviewing

1:52 pm

Zoltan Miskolci

More
8b54f61
changed 3 files
LDT-3735-non-volatile-memory, LDT-4003-hdf-fw-implementation-4-4 and 11 more LEAHI-DIALIN-LDT-4721-1

event fix

- -1
- +1
./events.py
- History
- Source
- Diff
./events.py
… 2 more files in changeset.

1:50 pm

Zoltan Miskolci

More
60a4cdf
changed 3 files
LDT-3735-non-volatile-memory, LDT-4003-hdf-fw-implementation-4-4 and 11 more LEAHI-DIALIN-LDT-4721-1 LEAHI-DIALIN-LDT-4484-1

Fixed non working modules

- -6
- +5
./pressure_sensors.py
- History
- Source
- Diff
./pressure_sensors.py
- -38
- +1
./syringe_pump.py
- History
- Source
- Diff
./syringe_pump.py
… 1 more file in changeset.

Friday 12 Jun

9:16 am

Dara Navaei

More
LEAHI-DIALIN-LDT-4721-1
started review

LEAHI-DIALIN-LDT-4721_Add extra parameter to start pregen request

LEAHI-DIALIN-LDT-4721_Add extra parameter to start pregen request

Thursday 11 Jun

1:30 pm

Sean Nash

More
LEAHI-DIALIN-LDT-4484-1
left review

1:30 pm

Sean Nash

More
LEAHI-DIALIN-LDT-3735-1
left review

Monday 08 Jun

11:20 am

Dara Navaei

More
LEAHI-DIALIN-LDT-4484-1
started review

LEAHI-DIALIN-LDT-4484_[Dialin] Create Dry Self Test module in dialin

LEAHI-DIALIN-LDT-4484_[Dialin] Create Dry Self Test module in dialin

Wednesday 03 Jun

5:02 pm

Dara Navaei

More
LEAHI-DIALIN-LDT-3735-1
started review

LEAHI-DIALIN-LDT-3735_System Data and Logs - DD - Non-Volatile Memory - 04: DEV - Feature Implementation

LEAHI-DIALIN-LDT-3735_System Data and Logs - DD - Non-Volatile Memory - 04: DEV - Feature Implementation

Monday 01 Jun

4:20 pm

Zoltan Miskolci

4:00 pm

Zoltan Miskolci

More
6c90336
changed 13 files
LDT-3735-non-volatile-memory, LDT-4001-hdf---fw-implementation-2-4 and 18 more LEAHI-DIALIN-LDT-4484-1 LEAHI-DIALIN-LDT-4001-1

Merge branch 'LDT-3904-opmode-the-operation-mode-broad' into staging

- -22
- +41
./syringe_pump.py
- History
- Source
- Diff
./syringe_pump.py
- -66
- +39
./valves.py
- History
- Source
- Diff
./valves.py
… 11 more files in changeset.

8:01 am

Raghu Kallala

More
LEAHI-DIALIN-LDT-3904-1
finished reviewing

Friday 29 May

10:05 am

Michael Garthwaite

More
LEAHI-DIALIN-LDT-3904-1
finished reviewing

Friday 22 May

11:34 am

Vendor - TEL - Arpita Srivastava

9:18 am

Michael Garthwaite

More
LEAHI-DIALIN-LDT-3505-1
finished reviewing

Thursday 21 May

5:09 pm

Zoltan Miskolci

references to Denali has been removed

references to Denali has been removed

3:59 pm

Zoltan Miskolci

More
3e6eac0
changed 2 files
LDT-3735-non-volatile-memory, LDT-4001-hdf---fw-implementation-2-4 and 18 more LEAHI-DIALIN-LDT-3904-1

fix

- -4
- +4
./events.py
- History
- Source
- Diff
./events.py
… 1 more file in changeset.

3:51 pm

Zoltan Miskolci

More
LEAHI-DIALIN-LDT-3505-1
finished reviewing

11:31 am

Zoltan Miskolci

More
1f2bf6d
changed 76 files
LDT-3735-non-volatile-memory, LDT-4001-hdf---fw-implementation-2-4 and 18 more LEAHI-DIALIN-LDT-3904-1 LEAHI-DIALIN-LDT-4001-1 LEAHI-DIALIN-LDT-4484-1

Removed Denali reference

- -6
- +6
./air_pump.py
- History
- Source
- Diff
./air_pump.py
- -11
- +11
./air_trap.py
- History
- Source
- Diff
./air_trap.py
- -20
- +20
./alarms.py
- History
- Source
- Diff
./alarms.py
- -15
- +15
./blood_flow.py
- History
- Source
- Diff
./blood_flow.py
- -7
- +7
./bubble_detector.py
- History
- Source
- Diff
./bubble_detector.py
- -6
- +6
./buttons.py
- History
- Source
- Diff
./buttons.py
- -8
- +8
./ejector.py
- History
- Source
- Diff
./ejector.py
- -5
- +5
./events.py
- History
- Source
- Diff
./events.py
- -7
- +7
./pressure_sensors.py
- History
- Source
- Diff
./pressure_sensors.py
- -5
- +5
./switches.py
- History
- Source
- Diff
./switches.py
- -7
- +7
./td_test_configs.py
- History
- Source
- Diff
./td_test_configs.py
- -5
- +5
./temperature_sensors.py
- History
- Source
- Diff
./temperature_sensors.py
- -9
- +9
./treatment.py
- History
- Source
- Diff
./treatment.py
- -10
- +10
./valves.py
- History
- Source
- Diff
./valves.py
- -5
- +5
./voltages.py
- History
- Source
- Diff
./voltages.py
… 61 more files in changeset.

7:44 am

Raghu Kallala

More
Re: LEAHI-DIALIN-LDT-3904-1
commented on review

Shouldn't we use Leahi instead of Denali?

Shouldn't we use Leahi instead of Denali?

Monday 18 May

2:16 pm

Sean Nash

More
LEAHI-DIALIN-LDT-3505-1
resumed reviewing

2:15 pm

Vendor - TEL - Arpita Srivastava

More
8fbb7b6
changed 2 files
LDT-3505-heparin-td-04-dev-feature-implemenation, LDT-3735-non-volatile-memory and 19 more LEAHI-DIALIN-LDT-3505-1

LDT-3505: Updated Force Sensor Calibration function

- -35
- +29
./syringe_pump.py
- History
- Source
- Diff
./syringe_pump.py
… 1 more file in changeset.

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-06-26 06:51 -0700