Clone
 

behrouz nemaipour <bnematipour@diality.com> in application

DEN-3883: Coverage

- DGCheckIn message

    • -0
    • +2
    /sources/canbus/messageinterpreter.cpp
DEN-3883: Coverage

    • -20
    • +14
    /sources/canbus/messageinterpreter.cpp
    • -0
    • +1
    /sources/gui/qml/pages/SettingsHome.qml
    • -65
    • +67
    /sources/model/hd/alarm/MAlarmStatusData.cpp
    • -2
    • +9
    /sources/model/hd/alarm/MAlarmStatusData.h
4246: Merge Newly added Squish API Messages into Dial-In

- Has not been merged yet but preparing for.

    • -9
    • +9
    /sources/gui/qml/pages/ManagerHome.qml
    • -1
    • +2
    /sources/gui/qml/pages/SettingsHome.qml
    • -0
    • +9
    /sources/model/hd/data/MTreatmentFlowsData.h
    • -0
    • +6
    /sources/model/hd/data/MTreatmentTimeData.h
    • -0
    • +2
    /sources/view/dg/data/VDGValvesStatesData.h
3883: Coverage

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -2
    • +2
    /sources/canbus/messageinterpreter.cpp
DEN-3881: Unit Testing

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -32
    • +24
    /sources/canbus/messageinterpreter.cpp
SRSUI 669: Current Duration

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

DEN-4002: Implementation 2 [SRSUI 476: Log files rotation]

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -6
    • +9
    /sources/canbus/messageinterpreter.cpp
DEN-4002: Implementation 2 [SRSUI 476: Log files rotation]

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

DEN-4002: Implementation 2 [SRSUI 476: Log files rotation]

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -2
    • +5
    /sources/canbus/messageinterpreter.cpp
DEN-4002: Implementation 2 [SRSUI 476: Log files rotation]

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -1
    • +1
    /sources/canbus/messageacknowmodel.cpp
    • -7
    • +24
    /sources/canbus/messageinterpreter.cpp
    • -3
    • +5
    /sources/model/dg/data/MDGDrainPumpData.h
    • -3
    • +5
    /sources/model/dg/data/MDGHeatersData.h
  1. … 33 more files in changeset.
DEN-4002: Implementation 2 [SRSUI 476: Log files rotation]

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

DEN-4002 : Implementation 2

- Improvements of log text and so .

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -38
    • +32
    /sources/canbus/messageinterpreter.cpp
FW Support for HD/DG Debug Text & HDOpMode.

- Added a newly added channel to the list of listened channels eChlid_DG_UI = 0x070

- The MessageBuilder::getActionId implementation has been improved.

- New Messages has been added and enum/length defined as well.

- Message interpreter code has been improved to be easily modifiable.

- Changed the message ID enum ID_PowerOffBroadcast to ID_ShuttingDown.

- Added HDOperationMode to the setting screen.

- Made the floating point rounding optional by a #define and disabled the rounding for now.

- Inherit the MPowerOff Model from MAbstract as a new design.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -36
    • +42
    /sources/canbus/messageglobals.h
    • -60
    • +37
    /sources/canbus/messageinterpreter.cpp
    • -2
    • +27
    /sources/gui/qml/pages/SettingsHome.qml
    • -0
    • +35
    /sources/model/MDGDebugText.cpp
  1. … 17 more files in changeset.
DEN-3880 : Implementation

- Added application name and version in the log.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

DEN-3874 : HW Support [Per Peman's Email]

- Reversed the ValvesState view order.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -12
    • +12
    /sources/view/dg/data/VDGValvesStatesData.cpp
DEN-3874 : HW Support [Per Peman's Email]

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -1
    • +1
    /sources/canbus/messageinterpreter.cpp
DEN-3874 : HW Support [Per Peman's Email]

- Unified All the Data messages to use the newly created parent model MAbstract.

- Cleaned up the logging class.

- Removed log_once macros.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -257
    • +29
    /sources/canbus/messageinterpreter.cpp
    • -25
    • +13
    /sources/canbus/messageinterpreter.h
    • -1
    • +1
    /sources/gui/qml/pages/SettingsHome.qml
    • -1
    • +1
    /sources/model/dg/data/MDGDrainPumpData.h
  1. … 17 more files in changeset.
DEN-3874 : HW Support [Per Peman's Email]

- Another try to make the code more clean.

- Qml doesn't accept enums with first letter non-capital [id => ID_]

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -36
    • +36
    /sources/canbus/messageglobals.h
    • -64
    • +64
    /sources/canbus/messageinterpreter.cpp
    • -1
    • +1
    /sources/gui/qml/pages/ManagerHome.qml
    • -0
    • +47
    /sources/model/MAbstract.cpp
    • -9
    • +5
    /sources/model/dg/data/MDGDrainPumpData.cpp
  1. … 17 more files in changeset.
DEN-3874 : HW Support [Per Peman's Email]

- Just to keep the code. Needs clean up.

- Don't forget Logs (DG, HD is different)

- So many more.

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -29
    • +40
    /sources/canbus/messageglobals.h
    • -98
    • +89
    /sources/canbus/messageinterpreter.cpp
  1. … 127 more files in changeset.
DEN-3880 : Implementation

- Added Alarm Triggered Model

- Added Alarm Cleared Model

- Added Treatment State Model

- "UI," as Event Source to the Initialized and Some Other Event Messages for better logging

- Updated Ack messages and made them nicer for logging.

- Added DGCheckIn as a message to be logged.

- Stored Unit texts as a read only property in Variables qml file which had multiple definition multiple places.

- Changed the toString of models to use comma instead of parenthesis to be easily used in Excel as a CSV file format.

- Found a bug in TreatmentAdjustmentUltrafiltrationConfirm Screen slot which had volume defined as int that actually is a float value and causes the float to be truncated also the volume should be traslated int the VTreatmentAdjustmentUltrafiltratinConfirm to mL from Liter. Although HD wasn't using that value and was not complaining about it.

- Changed the current pew-set Volume value in the TreatmentAdjustmentUltrafiltrationEdit screen to be the current max value which is actually going to be changed by user.

- Changed to use the reference Volume to be used as the current collected volume in the Ultrafiltration section of the main treatment screen and the other Ultrafiltration adjustment screen that using it (Start. Paused, Edit).

- Added toString to the request models to be used for logging.

- Refactored the Message Interpreter response methods to be unique like the other improved latest methods (get<Method>s removed) [Reordered, Document cleanup, and so].

- Updated the manual in the MModel header for creating a model in regards to refactoring above.

- Updated Response Models in regards to the refactoring above.

- Made each byte space separator in Flags class in Types class for cleaner logging (will be used empty string in Alarm Status for logging).

- Changed the logging folder to be log folder (not event, error) and changed the log file extension for events/data to be .log and for errors to be .err.

- log file format modified to be CSV.

- Removed a not used fromByteArrayState method of mtreatmentadjustmentultrafiltrationconfirmresponse , mtreatmentadjustmentultrafiltrationeditresponse.

________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -459
    • +362
    /sources/canbus/messageinterpreter.cpp
    • -63
    • +38
    /sources/canbus/messageinterpreter.h
  1. … 48 more files in changeset.
Merge branch 'DEN-3149_TreatmentUltrafiltrationAdjustment'

DEN-3158 : Code Review 0

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -1
    • +1
    /sources/model/mtreatmentadjustultrafiltrationstateresponse.h
DEN-3157 : Code Coverage

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -1
    • +1
    /sources/model/mtreatmentadjustrequests.h
    • -12
    • +6
    /sources/view/vtreatmentadjustmentultrafiltrationstate.cpp
DEN-3157 : Code Coverage

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -7
    • +7
    /sources/canbus/messageinterpreter.cpp
    • -2
    • +2
    /sources/gui/qml/pages/SettingsHome.qml
    • -1
    • +1
    /sources/model/mtreatmentadjustultrafiltrationstateresponse.h
    • -3
    • +7
    /sources/view/vtreatmentadjustmentultrafiltrationstate.cpp
DEN-3157 : Code Coverage

- DEN-3158 : Code Review 0

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

DEN-3156 Integration Testing

- 90.849% (1916/2109)

________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -2
    • +4
    /sources/gui/qml/pages/SettingsHome.qml
    • -1
    • +4
    /sources/view/vtreatmentadjustmentultrafiltrationconfirm.h
    • -0
    • +2
    /sources/view/vtreatmentultrafiltration.h
DEN-3155 : Unit Testing

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -2
    • +1
    /sources/canbus/messageinterpreter.cpp
    • -1
    • +5
    /sources/view/vtreatmentadjustmentresponsebase.cpp
DEN-3155 : Unit Testing

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -1
    • +0
    /sources/gui/qml/components/MainMenu.qml
    • -0
    • +2
    /sources/gui/qml/components/ModalDialog.qml
    • -0
    • +2
    /sources/gui/qml/dialogs/AutoHideInfo.qml
DEN-3158 : Code Review 0

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -2
    • +2
    /sources/gui/qml/components/TouchRect.qml
DEN-3158 : Code Review 0

__________________________________________________________________________________

Behrouz NematiPour

bNematiPour@diality.com

    • -8
    • +8
    /sources/canbus/messageinterpreter.cpp