•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-4860-BLE-1 13 Jan 2021

why this folder has to exist and why this naming has been chosen?

UI-DEN-4860-BLE-1 18 Jan 2021

RESOLVED

UI-DEN-4860-BLE-1 18 Jan 2021

RESOLVED

HD-DEN-6402-1 03 Feb 2021

Done.

HD-DEN-6200-1 20 Jan 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6200-1 20 Jan 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-6200-1 20 Jan 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6402-1 09 Feb 2021

Removed. Pause state should be handled by sub-mode.

UI-DEN-6349-1 18 Jan 2021

This is a leak/bug.
Leak: A pointer to an object has been removed from the list and the object still exists and utilizing the memory (bug: and may even still doing some tasks).

UI-DEN-6349-1 24 Jan 2021

This is not a prefered approach and there are better ways of doing it.
As Qt mentions in the document:


QAbstractItemModel Subclass
A model can be defined by subclassing QAbstractItemModel. This is the best approach if you have a more complex model that cannot be supported by the other approaches. A QAbstractItemModel can also automatically notify a QML view when the model data changes.

HD-DEN-6372-1 11 Feb 2021

These are both engineering build switches (HDCommon.h). If either build switch is enabled, this code will not be compiled.

DIALIN-DEN-5830-2 19 Jan 2021

moved to tools folder

DIALIN-DEN-5830-2 13 Jan 2021

This should go in the tools directory with the other helper scripts

HD-DEN-6372-1 11 Feb 2021

Is the stop button still part of the design? And why are we ignoring it here?

HD-DEN-6200-1 20 Jan 2021

Signals have been forwarded to appropriate sub-mode to handle.

HD-DEN-6402-1 10 Feb 2021

Do we need a setting for normal control via active reservoir? Or will the next cmdSetDGActiveReservoir command put the valves back in a normal state?

DG-DEN-6200-1 21 Jan 2021

Reverted the deletion.

HD-DEN-6200-1 21 Jan 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-6200-1 21 Jan 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-6200-1 21 Jan 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-6200-1 21 Jan 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-6402-1 11 Feb 2021

This is doxygen style comment if not in the same line.

HD-DEN-6200-1 21 Jan 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6372-1 11 Feb 2021

Delete or add TODO comment.

HD-DEN-6402-1 11 Feb 2021

Remove extra "/" from comment.

UI-DEN-6349-1 24 Jan 2021

RESOLVED

HD-DEN-6402-1 11 Feb 2021

Remove extra "/" from comment.

HD-DEN-6372-1 11 Feb 2021

Do we need a #define for 1.2?

DIALIN-DEN-5638-1 25 Jan 2021

Looks like it has not been used anymore so I've deleted it.

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6402-1 01 Feb 2021

Check for door open before running self-tests. Really, self-test execution should go last and only if no door open and no stop signal.

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-5638-1 24 Jan 2021

what is this commit and why it has been mentioned here?
how is this going to be maintained?

HD-DEN-6402-1 08 Feb 2021

If not yet in fill mode, will dgCmdResp persist to next time?

HD-DEN-6402-1 11 Feb 2021

This is doxygen style comment if not in the same line.

UI-DEN-5638-1 26 Jan 2021

I agree. To ensure I don't miss additional instances of HDSimulator I'll make this change on the latest testsuites branch I'm working on.

HD-DEN-6402-1 11 Feb 2021

This is doxygen style comment if not in the same line.

UI-DEN-5638-1 26 Jan 2021

Please consider changing the instance name to hd_simulator.
The name of variables is always important, especially in this case which makes it confusing since the name of the class and the variable are the same.

HD-DEN-6402-1 11 Feb 2021

This is doxygen style comment if not in the same line.

HD-DEN-6402-1 11 Feb 2021

This is doxygen style comment if not in the same line.

DG-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-5638-1 26 Jan 2021

Tx_States violates the CapWords convention for classes as per our coding standard, as no underscores should be present between words in a class name.
TreatmentStates is clearer than TxStates. Tx could easily be confused with transmit...

HD-DEN-6402-1 11 Feb 2021

Remove extra "/" from comment.

UI-DEN-6349-1 24 Jan 2021

what is this?
why created and why ignored?

HD-DEN-6890-1 09 Mar 2021

Addressed.

HD-DEN-6890-1 09 Mar 2021

Addressed.

DG-DEN-6890-1 10 Mar 2021

Added.

UI-DEN-7135-1 10 Apr 2021

RESOLVED.

UI-DEN-4860-BLE-1 18 Jan 2021

Please note that the code review has to be automatic, by making it manual and mixed up with other features, this may happen.
RESOLVED

UI-DEN-4964-1 02 Feb 2021

RESOLVED