•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-6402-1 01 Feb 2021

I think this function is too big. I generally prefer to have static functions to call for each case unless it's a one-liner to keep the switch state from getting too big.

HD-DEN-6402-1 11 Feb 2021

Don't we need to tell it also which valves setting we are moving towards? I guess I am unclear about the purpose of this one flag in this enumerator.

HD-DEN-7395-1 08 Apr 2021

Addressed.

HD-DEN-5980-1 22 Mar 2021

Done

HD-DEN-7091-1 01 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 07 Apr 2021

load cell enum needs to be fixed.

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 22 Mar 2021

Can we log 2 data with alarms (set alarm and a data value when detected, log with alarm here)?

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7395-1 24 Mar 2021

We should consider adding Dialin options to zero sensor and initiate self-test.

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 08 Apr 2021

Why commented out?

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6402-1 08 Feb 2021

This function is too big. Create static functions to handle these switch cases.

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-6402-1 11 Feb 2021

Remove extra "/" from comment.

HD-DEN-6402-1 11 Feb 2021

This is doxygen style comment if not in the same line.

HD-DEN-6402-1 11 Feb 2021

This is doxygen style comment if not in the same line.

HD-DEN-6402-1 11 Feb 2021

This is doxygen style comment if not in the same line.

DG-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-6402-1 11 Feb 2021

I would imagine there will be many more valve settings for the various modes/states and sub-modes/sub-states.

HD-DEN-6402-1 11 Feb 2021

Delete or add TODO comment.

HD-DEN-6402-1 11 Feb 2021

Remove all extra "/" from all comments.

HD-DEN-6402-1 11 Feb 2021

Remove extra "/" from comment.

HD-DEN-6402-1 11 Feb 2021

Remove extra "/" from comment.

HD-DEN-6402-1 11 Feb 2021

Remove extra "/" from comment.

HD-DEN-6372-1 03 Mar 2021

Fixed.

HD-DEN-6372-1 03 Mar 2021

Need to fix doxygen style.
@details Inputs:
@details Outputs:

HD-DEN-5980-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5980-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5980-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5980-1 23 Mar 2021

Not just for calibration record.

DG-DEN-5980-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5980-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5980-1 23 Mar 2021

Update to new build switch.

DG-DEN-5980-1 22 Feb 2021

Why are all of these commented out?

UI-DEN-7035-1 24 Mar 2021

Did you do the Code Coverage?
If not please remove these lines which I think are the leftovers of copy/paste.
so later we test them.

DG-DEN-5980-1 24 Mar 2021

These string fields are not null terminated. We will used them as characters and they are not used anywhere in the firmware.

DG-DEN-5980-1 23 Mar 2021

Why do we need to disable interrupt? Is it a critical function?

DG-DEN-5980-1 24 Mar 2021

To make sure dequeuing is not interrupted.

DG-DEN-6200-1 15 Jan 2021

Extra spaces is to keep all the variables align.
Removed extra space below to keep alignment.

HD-DEN-9906-1 15 Nov 2021

This should be an F64.

HD-DEN-6890-1 09 Mar 2021

Addressed.

UI-DEN-6349-1 18 Jan 2021

For VBluetoothDeviceInfo's usage in QML, see SettingsBluetooth.qml lines 204, lines 212

 text: modelData.name 

and

 text: modelData.address 


These properties are defined in VBluetoothDeviceInfo.h

UI-DEN-6349-1 15 Jan 2021

The code review has to be automatic.
It has to be added to the code review by Crucible not the developer as of our process.
Please create code reviews that are automatic and not modified by the developer otherwise it would be out of context and useless.

HD-DEN-6402-1 01 Feb 2021

1) When we fail this test, we only alarm to let the user know and take action.
2) We should. The alarms activation will be moved into this function.

UI-DEN-5830-2 15 Jan 2021

RESOLVED.

HD-DEN-6402-1 11 Feb 2021

This is doxygen style comment if not in the same line.