Comment Search

Should we check door before we run the self tests?

1. How are we syncing times between UI RTC and HD RTC?
2. Does not the UI APP know some of these times (like start time) to compute the other times by itself instead of HD FW passing them to the UI APP?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

This is doxygen style comment if not in the same line.

Remove all extra "/" from all comments.

Need an extra line.

Just delete this case.

Consider moving this assignment to declaration above. Also, readings in comment above should be singular. Also, consider renaming "state" to something like noFluidLeakDetected.

RESOLVED in CODE WALKTHROUGH.

Done.

couldn't we use the date command instead which is more common?

• since you are setting the bottom margin we need to think about the object that are showing up on the bottom of the screen and since the mainMenu comes on top then it's height may not be relevant to the bottom of the screen area.
  Could be better to use notificationHeight which is used for the notifications that are showing up at the bottom.
• why it has been used by twise the size?

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Consider turning these into Enums.

This is in fwcommon so it has to be able to cover both stacks.

If the flow sensor is bad, we will go to fault. In this case, the calibration does not matter anymore.

Done.

RESOLVED in CODE WALKTHROUGH.

Remove extra spaces before = sign.

please put the even verb at the end.
pressedEnter => enterPressed
eg.
clickedBack => backClicked
clickedContinue => continueClicked

**"please follow this everywhere in the code."**

Removed this sub-mode.

Calibration factors live in non-volatile memory. Set during calibration via Dialin.

Not fully clear what the sub-modes of service mode will be. At this time, I don't know what, if anything, should happen if the user presses the stop/pause button while in service mode. For now, there is nothing to stop so we are ignoring.