•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-6402-1 01 Feb 2021

Add _MS to end to indicate units of time. Also, is this a self-test for blood pump occlusion sensor? If so, maybe replace "PRESSURE" with "OCCLUSION" to clarify.

HD-DEN-6402-1 09 Feb 2021

Fixed. Now store command response for each possible commands rather than one command response for all commands.

UI-DEN-7135-1 09 Apr 2021

Tried to Clarified.
When wanted to explain in only one line very briefly it becomes confusing.

HD-DEN-6402-1 09 Feb 2021

Removed. This has been converted to pre-treatment recirculate sub-mode state.

UI-DEN-7135-1 09 Apr 2021

done

HD-DEN-6402-1 09 Feb 2021

Removed the sub-mode. Each sub-mode will have their pause/stopped state.

UI-DEN-7135-1 09 Apr 2021

done

DG-DEN-6402-1 11 Feb 2021

Added maximum 5 times retry before alarm.

UI-DEN-7135-1 09 Apr 2021

done

UI-DEN-7135-1 10 Apr 2021

RESOLVED.

HD-DEN-6402-1 11 Feb 2021

Align the comment.

HD-DEN-6372-1 11 Feb 2021

Removed.

DG-DEN-6402-1 10 Feb 2021

Should this be moved to common\DG_Defs.h? I see HD has same typedef.

DG-DEN-6402-1 11 Feb 2021

SYS team would like to lower down RPM since there is a risk of making the drain pump goes bad at 2800 RPM.

HD-DEN-6372-1 11 Feb 2021

Something to consider, but I think we are too far into development to make a change like that. We have a lot of unit test cases looking for variables as they are currently named. A large refactor would kill our dev testing.

HD-DEN-6372-1 11 Feb 2021

Already have a TODO on line 32.

HD-DEN-6372-1 11 Feb 2021

Add TODO comments or delete.

DG-DEN-6402-1 11 Feb 2021

This is a doxygen style comment. Not a general code comment.

DG-DEN-6402-1 11 Feb 2021

Removed.

DG-DEN-6402-1 11 Feb 2021

Are we planning to provide pressure in float? Like 30.25 psi?

DG-DEN-6402-1 11 Feb 2021

Isn't this already defined somewhere else? It seems redundant.

HD-DEN-6372-1 11 Feb 2021

This is the reason why at one of my previous companies we used to name variables with f_ or i_ as first characters to know at a glance the variable type definition. Now worth considering though.

HD-DEN-6372-1 11 Feb 2021

Replace with function that sets these valves. Settings valves can be its own module for the various modes/sates and sub-modes/sub-states. This same concept can be applied to all actuators where in mode/sate or sub-mode/sub-state, the valves, the pumps, etc. are all set. I would like to avoid setting just the valves manually here and again manually set somewhere else. Let's keep all states centralized per mode/sub-mode or state/sub-state.

UI-DEN-4860-BLE-1 13 Jan 2021

Please put a comment about why sleep 5 has been used and what needs to be done to remove this sleep.

UI-DEN-7044-1 08 Apr 2021

Done

DG-DEN-12931-1 03 Aug 2022

Done.

UI-DEN-6349-1 14 Jan 2021

Done

UI-DEN-7135-1 09 Apr 2021

Added your suggested wording.

UI-DEN-5830-2 15 Jan 2021

RESOLVED

UI-DEN-7135-1 09 Apr 2021

done

HD-DEN-6200-1 18 Jan 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6200-1 15 Jan 2021

Maybe just call init function above in case other inits get added there?

HD-DEN-6402-1 03 Feb 2021

Agree. All multi-lines state have been moved to a static function.

UI-DEN-6349-1 18 Jan 2021

RESOLVED

HD-DEN-7395-1 09 Apr 2021

Need to add call to this function from task priority.

HD-DEN-6402-1 11 Feb 2021

Remove all extra "/" from all comments.

DG-DEN-6402-1 11 Feb 2021

We have slowed down the RO pump flow rate for drain mode. so the RO pump flow rate should not affect the drain process much.

DG-DEN-6402-1 11 Feb 2021

Agreed. Moved to DGDefs.h

HD-DEN-6372-1 11 Feb 2021

What is 2.0? Can it be defined as a constant to provide more definition?

HD-DEN-6372-1 11 Feb 2021

In my opinion, no. Should be clear I am setting safety margin at 120% of target volume. This constant is essentially a #define itself.

HD-DEN-5887-1 11 Feb 2021

Delta is between prior reservoir weight (50 ms ago) and current reservoir weight. Both are filtered (moving avg over 800 ms). Looking for load cell interference (maybe somebody bumped the table that the system is sitting on). Want to pause treatment to allow interference to resolve and prevent bad load cell data from getting into ultrafiltration tracking logic (e.g. if load cell jumps up significantly, UF logic might wrongfully determine that we have reached our target UF volume way too early).

DG-DEN-6402-1 11 Feb 2021

Those valve settings might not be of interest to the HD and should stay local to DG.
For now, HD is interest in these two valve settings for wet self-tests.

DG-DEN-6402-1 11 Feb 2021

This is our desired flow rate that we would like the controller to achieve.

DG-DEN-6402-1 11 Feb 2021

May be moot after change to flow control.

HD-DEN-6372-1 11 Feb 2021

Where is bloodFlowCalGain defined and what is its value? Is it fixed across machines or does it get set at calibration time?

HD-DEN-6402-1 11 Feb 2021

Remove extra "/" from comment.

HD-DEN-6402-1 11 Feb 2021

Remove extra "/" from comment.

HD-DEN-6402-1 11 Feb 2021

Remove extra "/" from comment.

HD-DEN-6402-1 11 Feb 2021

Remove extra "/" from comment.

HD-DEN-6402-1 11 Feb 2021

Remove extra "/" from comment.