•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-5980-1 27 Mar 2021

Revert line deletion.

HD-DEN-7347-1 01 Apr 2021

FALSE value on the function above does not necessarily mean all of the occlusion sensors' reading is below the threshold. It can be one of them is below the threshold.
This function makes sure all of them are below the threshold.

DIALIN-DEN-5980-1 01 Apr 2021

Done.

UI-DEN-7044-1 01 Apr 2021

It is now removed, WifiNetworkData is added to REGISTER_MODEL_METATYPES now

DIALIN-DEN-5980-1 01 Apr 2021

RESOLVED

DIALIN-DEN-5980-1 01 Apr 2021

RESOLVED

DIALIN-DEN-5980-1 01 Apr 2021

It looks like all instances of length were renamed to received_msg_length in 551e0a9620126efd158e93c45e9ed84ee6ec85fb

UI-DEN-7135-1 01 Apr 2021

It's working on the Sprint37 branch of the Common.
FW hasn't updated on the master yet.

HD-DEN-7347-1 01 Apr 2021

Done.

HD-DEN-7117-1 02 Apr 2021

Done.

UI-DEN-5777-1 01 Feb 2021

Did you mean retained? If so, change all these to retained as well as hte name of the quint8 variable to vRetainedPercent.

UI-DEN-5751-1 01 Feb 2021

will be addressed later,
RESOLVED

UI-DEN-5751-1 01 Feb 2021

will be addressed later,
RESOLVED

HD-DEN-6402-1 11 Feb 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7395-1 12 Apr 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7091-1 28 Feb 2021

Removed. It was leftover when battery exec function was called from general task.

HD-DEN-7395-1 12 Apr 2021

Addressed.

HD-DEN-7117-1 23 Mar 2021

It is volts. Everywhere else we use abbreviated units of measure as suffix (e.g. _ML).

DG-DEN-6200-1 14 Jan 2021

On the DG side, I move this function into Alarm Management module. I find it better than individually handle them one by one and it still gives flexibility in case we need to handle another persistent alarm differently.

HD-DEN-6372-1 01 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-9906-1 15 Nov 2021

Add variable in line 386 to @detail Inputs & Outputs

DD-LEAH-225-1 16 Oct 2024

Remove extra space before "=".

HD-DEN-6372-1 01 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6200-1 15 Jan 2021

I know, but the clearing occurs before the mode gets this signal (see signalAlarmUserActionInitiated() in AlarmMgmt.c). So you don't need to clear it again here.

HD-DEN-7395-1 01 Apr 2021

Was this function temporary too?

HD-DEN-14344-3 23 Nov 2022

Fixed. Thanks!

DG-DEN-5963-1 22 Mar 2021

Set these booleans to TRUE or FALSE explicitly.

DG-DEN-5963-1 08 Apr 2021

Comments shall start with capital letter.

DG-DEN-5963-1 22 Mar 2021

What is this state doing?

UI-DEN-4860-BLE-1 15 Jan 2021

RESOLVED

HD-DEN-6200-1 15 Jan 2021

Removed alarm clear action.

HD-DEN-6200-1 15 Jan 2021

Is half fill appropriate for both reservoirs? I think we need a TODO here to determine the fill volume we want for each reservoir and I believe they will be different in the end so we probably need two #defines here.

HD-DEN-5980-1 22 Mar 2021

I am not sure. I un-commented it.

HD-DEN-6200-1 18 Jan 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-6078-1 14 Jan 2021

Do we need this import?

HD-DEN-5980-1 22 Mar 2021

fwcommon had to be updated with latest changes. They are un-commented.

DIALIN-DEN-5980-1 23 Mar 2021

Transferred it to nv_ops_utils module.

HD-DEN-5980-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5980-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7091-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-7091-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-5980-1 23 Mar 2021

I renamed it.

DIALIN-DEN-5980-1 12 Feb 2021

This is a good place to use the logger (e.g. self.logger.debug(...)) instead of print

UI-DEN-7035-1 24 Mar 2021

RESOLVED.

UI-DEN-7035-1 24 Mar 2021

I see that you nicely put the _keyboard.setVisible(true) in the TextEntry component.
Don't you think it would be better to put _keyboard.setVisible(false) on onEnteredPressed in the TextEntry component as well, somewehere next to the lines below?

onFocusChanged: {
    if (focus) {ome whereo
        selectAll()
        _keyboard.setVisible(true)
    }
}

onAccepted: {
    _root.enterPressed()
} 
DIALIN-DEN-5980-1 25 Mar 2021

RESOLVED.

DIALIN-DEN-5980-1 25 Mar 2021

RESOLVED.

HD-DEN-7395-1 25 Mar 2021

Deleted.

HD-DEN-7395-1 24 Mar 2021

Should be 0x1000?
And shouldn't we add another mask for blood leak zero state (0x2000)?

HD-DEN-7395-1 26 Mar 2021

RESOLVED in CODE WALKTHROUGH.