•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-5980-1 23 Mar 2021

Do we want these header files to have a separate doxygen group name? I think we should have all of the NV data files (.h and .c) sharing the same group.

HD-DEN-5980-1 29 Mar 2021

This function has been removed.

DIALIN-DEN-5980-1 01 Apr 2021

Done.

UI-DEN-7044-1 01 Apr 2021

Just tested this and confirmed the alarm dialog shows up in front of the join / disconnect dialog

UI-DEN-7044-1 01 Apr 2021

Done

DIALIN-DEN-5980-1 01 Apr 2021

This should be received_msg_length

HD-DEN-5980-1 02 Apr 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7117-1 02 Apr 2021

Compiler will not allow numeric start to a #define name.

HD-DEN-7117-1 02 Apr 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5980-1 02 Apr 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5980-1 24 Mar 2021

Add TODO to commented line.

DG-DEN-5963-1 03 Apr 2021

Done.

DG-DEN-5963-1 03 Apr 2021

I do not know what happened. I brought it back.

UI-DEN-7135-1 05 Apr 2021

RESOLVED

HD-DEN-7117-1 05 Apr 2021

This message should be MSG_ID_UI_INITIATE_TREATMENT_REQUEST.

UI-DEN-5777-1 01 Feb 2021

RESOLVED.

HD-DEN-7395-1 08 Apr 2021

Addressed.

UI-DEN-5751-1 01 Feb 2021

RESOLVED

HD-DEN-12224-16 23 May 2022

Remove blank line.

HD-DEN-5980-1 24 Mar 2021

Add TODO.

DG-DEN-12931-1 03 Aug 2022

These have been fixed in DEN-13460.

UI-DEN-7135-1 09 Apr 2021

Removed.

HD-DEN-7091-1 01 Mar 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-7135-1 09 Apr 2021

Sorry, forgot.
Added.

DG-DEN-6200-1 14 Jan 2021

This does not look compatible with changes to PersistentAlarm module. Does this compile? I see this everywhere. I suspect you changed all of these and just need to push main DG branch.

UI-DEN-6349-1 14 Jan 2021

Like the other view classes that have 'V' as a prefix, the VBluetoothDeviceInfo has properties that are accessed directly by the QML
It could be called BluetoothDeviceInfo instead? Or, what would you prefer?

HD-DEN-6890-1 09 Mar 2021

Addressed.

UI-DEN-7135-1 01 Apr 2021

...instruction-based...

HD-DEN-5980-1 22 Mar 2021

Done.

UI-DEN-4860-BLE-1 14 Jan 2021

Perfect,
RESOLVED.

UI-DEN-7135-1 10 Apr 2021

RESOLVED.

HD-DEN-5980-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-6200-1 15 Jan 2021

Combined getAlarmId and isAlarmActive functions.

HD-DEN-6200-1 15 Jan 2021

Do we need to wait until we're done with first part of dialysate prime (or at least check to make sure it's already done) before we switch reservoirs?

UI-DEN-7135-1 10 Apr 2021

RESOLVED.

DG-DEN-6200-1 18 Jan 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-5980-1 24 Mar 2021

RESOLVED

HD-DEN-7395-1 10 Apr 2021

Addressed.

HD-DEN-5980-1 24 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5980-1 24 Mar 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-7135-1 05 Apr 2021

Is this needed or can it be deleted?

HD-DEN-5980-1 26 Mar 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-7135-1 12 Apr 2021

RESOLVED

DIALIN-DEN-7135-1 01 Apr 2021

Either remove commented lines or add TODO in comment.

UI-DEN-7035-1 24 Mar 2021

Done

UI-DEN-7035-1 24 Mar 2021

Please put more description of why we should have these two lines?

DG-DEN-5963-1 22 Mar 2021

Check these booleans explicitly.

DIALIN-DEN-5980-1 25 Mar 2021

RESOLVED.

DIALIN-DEN-5980-1 25 Mar 2021

RESOLVED.

HD-DEN-7395-1 25 Mar 2021

Addressed.