•  

Comment Results

Review Name Created Custom Fields Content
DIALIN-DEN-5980-1 28 Mar 2021

Done. Most of these test files will not be needed soon.

DG-DEN-5980-1 29 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5980-1 29 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5980-1 29 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5980-1 29 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5980-1 29 Mar 2021

It will be addressed in the future stories.

HD-DEN-5980-1 29 Mar 2021

The above line has been removed.

DIALIN-DEN-5980-1 29 Mar 2021

Fixed all the modules.

DIALIN-DEN-5980-1 01 Apr 2021

RESOLVED

DIALIN-DEN-5980-1 01 Apr 2021

RESOLVED

HD-DEN-5980-1 02 Apr 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-9906-1 12 Nov 2021

Finished implementing the TBD here.

UI-DEN-5830-2 14 Jan 2021

I kept it for debugging.
The usual behavior of the SquishQt is to continue even if an error happens to stop it if an error happens this value needs to be set.
I'm still trying to figure out how exactly this works and later may move it in a better file.

HD-DEN-5980-1 22 Feb 2021

Delete this case. Obsolete.

UI-DEN-5777-1 01 Feb 2021

I meant "retains" and "retain".
A complete sentence would be :
"if 90% retains ...." or
"if 90% shall retain"
I prefer to have a present verb, for input and if it was output, a past verb.

DG-DEN-6200-1 14 Jan 2021

Let's talk about it. If there's a good reason, fine. But generally I'd like HD and DG to do similar things in the same manner for consistency.

UI-DEN-5751-1 01 Feb 2021

will be addressed later,
RESOLVED

UI-DEN-5751-1 01 Feb 2021

created a sub-task for this as DoubleSlider doesn't have this validation/active feature.
// TODO : Will be addressed in sub-task DEN-6686.

UI-DEN-5830-2 12 Jan 2021

Can delete

UI-DEN-6349-1 15 Jan 2021

RESOLVED

HD-DEN-6200-1 15 Jan 2021

Added TODO.

DG-DEN-5980-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6200-1 15 Jan 2021

Done.

HD-DEN-6402-1 01 Feb 2021

So in this dry test, I guess if any one of these is out of range we can say something is wrong with the way the cartridge was loaded. Should we try to distinguish between improperly loaded cartridge and no cartridge loaded (all 3 occlusions are < threshold)?

HD-DEN-6200-1 15 Jan 2021

Done.

HD-DEN-6078-1 15 Jan 2021

Remove extra lines.

HD-DEN-6200-1 15 Jan 2021

Add extra line.

HD-DEN-6200-1 18 Jan 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6200-1 15 Jan 2021

What if DG does not go to drain mode (e.g. DG rejected drain command)? We will get stuck in this state. Let's discuss DG command handling - we may need to add more to DG response so HD can handle these types of issues.

HD-DEN-6372-1 28 Feb 2021

Aligned.

HD-DEN-6372-1 28 Feb 2021

RTCs are sync'd by UI sending its date/time to HD and DG f/w.
However, RTC time is not used for treatment time. Treatment time is accumulated using HD timer counter. HD then uses this and set treatment duration to calculate time remaining. All are then sent to UI regularly.

HD-DEN-7091-1 28 Feb 2021

No one is using this flag. This flag gets set to TRUE previously when the HD starts to command DG to sample water.
The DG sample water command consists of start, stop, end sample water. So this flag does not make sense anymore.

DIALIN-DEN-5980-1 23 Mar 2021

I made it a lower case name.

DG-DEN-7091-1 01 Mar 2021

I think setActiveReservoirCMD() sets activeReservoir.data for you. Redundant.

HD-DEN-6890-1 09 Mar 2021

Consider merging these two declarations.

HD-DEN-7091-1 22 Mar 2021

Done.

HD-DEN-5980-1 24 Mar 2021

Done.

HD-DEN-5980-1 22 Mar 2021

Are you really running this on an eval board? I removed this build switch a while back as nobody was using it anymore.

DIALIN-DEN-5980-1 24 Mar 2021

RESOLVED

HD-DEN-5980-1 24 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5980-1 24 Mar 2021

I wanted to use enum specifically for calibration purposes. Their names also contain the word CAL.

DIALIN-DEN-5980-1 25 Mar 2021

RESOLVED.

UI-DEN-7035-1 24 Mar 2021

Twice the size of the main menu height (140) happened to leave a good sized margin between minimized alarm + main menu and the save button.
I've updated it to be defined more clearly so the notification height (60) + the main menu height (70) + settingsNotificationMargin (10) decides the bottomMargin instead of just 2x the main menu height.

HD-DEN-7395-1 25 Mar 2021

What happened here? Why are these deleted? Looks like a lot of content in this module has been removed. Need to restore.

DIALIN-DEN-7117-1 26 Mar 2021

RESOLVED.

HD-DEN-5980-1 26 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5980-1 29 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5980-1 29 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5980-1 23 Mar 2021

I'm not sure an enum is what we want for mfg location. We don't want to have to make a new build every time we a new location is added. I think location should probably be a 3 or 4 character alpha-numeric location code.

DG-DEN-5980-1 22 Feb 2021

See comment above on send functions. Consider packaging the 3 U32s in a structure to reduce memcpys.