•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-5963-1 03 Apr 2021

This was in the flow chart. So far both values to do the difference comes from TRo so it should be tested in V3.

DG-DEN-5963-1 03 Apr 2021

No, this variable is used to time both the disinfect states.

DG-DEN-5963-1 03 Apr 2021

Done.

HD-DEN-7117-1 06 Apr 2021

Done.

UI-DEN-5777-1 01 Feb 2021

Corrected the sentences and updated "can't" to "cannot" everywhere in the file.

UI-DEN-5751-1 01 Feb 2021

will be addressed later
RESOLVED

HD-DEN-5980-1 22 Feb 2021

Why is this commented out?

DG-DEN-5963-1 22 Mar 2021

Is this the new "coldest spot" sensor?

DG-DEN-6200-1 15 Jan 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-6349-1 13 Jan 2021

the 'on' prefix shall be used for the private slots only.
seems like this is not the case here.
A better naming would be notifyStatusUpdate().

DG-DEN-5963-1 08 Apr 2021

Add TODO or delete.

HD-DEN-6200-1 15 Jan 2021

Done.

HD-DEN-6372-1 28 Feb 2021

Done.

HD-DEN-6200-1 18 Jan 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-12716-1 08 Sep 2022

RESOLVED.

HD-DEN-6200-1 18 Jan 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6200-1 15 Jan 2021

Why only this one alarm? I think wherever possible, we want to be more general about alarm user actions. If user chooses to end treatment in response to any alarm that didn't block that option, we should allow it.

HD-DEN-6372-1 01 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-8030-1 16 Jun 2021

It is no longer needed.

HD-DEN-6890-1 09 Mar 2021

Addressed.

HD-DEN-6890-1 09 Mar 2021

FluidLeak.h is included in SystemCommMessages.h, so not needed here.

HD-DEN-7091-1 22 Mar 2021

Combined air trap and bubble detectors into one used cartridge check.

HD-DEN-8103-1 23 Jun 2021

Duplicate declaration from line 330.

HD-DEN-5980-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-8103-1 25 Jun 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5980-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7117-1 22 Mar 2021

Added TODO for now.

HD-DEN-5980-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5980-1 22 Mar 2021

Rename this. This build switch for was eval board. No longer used.

HD-DEN-5980-1 22 Feb 2021

Move "//" to left for consistency.

HD-DEN-5980-1 22 Feb 2021

Why are all of these commented out?

DG-DEN-5980-1 22 Feb 2021

Why are all of these commented out?

HD-DEN-7091-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7091-1 23 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-5980-1 23 Mar 2021

Done

DIALIN-DEN-5980-1 24 Mar 2021

Not sure I follow - Call me when you have a second so we can discuss

DIALIN-DEN-5980-1 23 Mar 2021

I looked at struct's bytes size method. I made this function because the byte size should not be assumed in anyways, otherwise, the data will not be mapped correctly to the firmware structures.

HD-DEN-5980-1 24 Mar 2021

Done.

HD-DEN-7117-1 22 Mar 2021

Not better to use this instead? bloodPumpMotorEdgeCount += (U16)(delta);

HD-DEN-5980-1 23 Mar 2021

Uncomment this.

HD-DEN-5980-1 23 Mar 2021

Uncomment code.

HD-DEN-5980-1 24 Mar 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-7035-1 24 Mar 2021

RESOLVED

UI-DEN-7035-1 24 Mar 2021

There is one use case with the manual BP / HR entry where the keyboard is kept visible after the user presses 'Enter'. This allows the focus to move from systolic -> diastolic -> HR automatically without causing it to flash invisible and then visible. So at the time it was left it up to the developer of the component to decide when to minimize the keyboard in case it would need to stay up as they kept moved between input fields.

If we remove automatically transitioning from one input field to the next in the manual BP / HR entry pop up, then I'd say there's no reason not to hide the keyboard inside the TextEntry component when Enter is pressed.

UI-DEN-7035-1 24 Mar 2021

Recently I'm removing the "Response" from the log's "infoText" function, since the log already has the source we will see it is coming from HD/DG and it make the "Response" useless and gets more space only.
Please apply the same for the DG.
And don't forget to update the doxygen comment as well.

UI-DEN-7035-1 24 Mar 2021

RESOLVED

DIALIN-DEN-7117-1 24 Mar 2021

Done.

HD-DEN-7395-1 25 Mar 2021

Addressed.

HD-DEN-7395-1 25 Mar 2021

Addressed.

Had this as placeholder before looking at the schematics and EE HRS/HDD docs.

DIALIN-DEN-5980-1 25 Mar 2021

RESOLVED.