•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-6349-1 08 Jan 2021

Reviewers please note:

According to the qt virtual keyboard technical styling guide, here
it is recommended to use

 Src/qtvirtualkeyboard/src/virtualkeyboard/content/styles/default 

as a base for the custom style. The Qt virtual keyboard styling files (called default and retro) I could find are located here on our VM:

 /opt/Qt5.12.5/5.12.5/Src/qtvirtualkeyboard/src/virtualkeyboard/content/styles/default 


You'll notice that the Qt company has only provided the button images in the svg format. It appears they did this to allow for greater customization of the keyboard styling in the qml code.

I'm aware it has been decided to use pngs in the denali application. If requested, I can change the default Qt-provided keyboard style.qml file to use pngs instead of svgs.
It would be helpful before I do so to get feedback on the look and feel of the numeric keyboard so we have an agreed-upon style, size, and layout of the numeric keyboard, as converting the svgs to pngs will hard-code the styling.

UI-DEN-6349-1 13 Jan 2021

I've added the min/max values for systolic, diastolic, and HR to the Variables.qml file. They come from PRS 451, 452, and 453

UI-DEN-6349-1 12 Jan 2021

The json document holds the information about the BP cuffs we've paired with.
It is also helpful to format the paired device information into json so it can be stored to disk and then re-loaded easily so that we can automatically re-connect to the last selected BP cuff after a reboot.
The dereferencing and casting is needed to work with the ObjectList-based model approach.
All of the slots are there to receive data from the BLEScanner, so we can display available devices to connect to.
We emit signals when we want to connect/reconnect to a device, scan for devices, or request to save the paired devices to disk.

UI-DEN-6349-1 13 Jan 2021

RESOLVED

UI-DEN-4860-BLE-1 13 Jan 2021

This objectName is necessary for the added alarm tests to work, which also guarantees 100% code coverage on my branch
It is very helpful for Systems / SW V&V to have as many object names defined so they can write their own squishqt tests
In order for Systems / SW V&V to interact with the alarms and so the alarm tests can function, I think it should be kept

DIALIN-DEN-5830-2 13 Jan 2021

Unused import

TD-LDT-1886-7 20 Oct 2025

Remove the variable.

UI-DEN-6349-1 08 Jan 2021

why 9999 used for default value instead of zero?

HD-DEN-9480-1 11 Nov 2021

RESOLVED IN CODE WALKTHROUGH

DIALIN-DEN-9480-1 11 Nov 2021

Fixed the return.

HD-DEN-7395-1 08 Apr 2021

They publish two different values that can be set independently of each other.

UI-DEN-5830-2 14 Jan 2021

deleted.

HD-DEN-6200-1 15 Jan 2021

Moved reservoir switching to prime state machine.

UI-DEN-5751-1 01 Feb 2021

RESOLVED

DG-DEN-5963-1 08 Apr 2021

If both of these functions are using the same constant, why do we have two functions? Use just one (unless it is planned for them to inherit different constants down the road).

UI-DEN-7044-1 29 Mar 2021

Please Just make sure that the Alarm can show up and cover any dialog also.

DG-DEN-6200-1 14 Jan 2021

I know these enums are in a header file with "HD" in the name and so the HD_ prefix may seem unnecessary, but I was putting HD_ and DG_ prefixes on mode state enums in case the HD and DG had one or more modes with the same name (like Standby) so there would not be a conflict if somebody wanted to include both HD and DG definitions in there module.

DIALIN-DEN-5830-2 18 Jan 2021

It's not a separate repository it's just a folder in the dialin repository called "tools"
Right now this script exists in the root folder when it should reside in the "tools" directory

HD-DEN-6200-1 15 Jan 2021

The first part of dialysate prime actually waits for reservoir 1 to be complete and become active.

DIALIN-DEN-5830-2 14 Jan 2021

Sure,
I am testing the idea.
It's not mature yet.
Will complete that and will move in the script repository later and use that for all the three repositories.

HD-DEN-6402-1 01 Feb 2021

Name is too vague. Make it clear this minimum is for occlusion sensors. And also if this minimum applies to narrower scope(s) (like no cartridge or dry or wet) or is it general and should never be less than this?

UI-DEN-6349-1 18 Jan 2021

RESOLVED

HD-DEN-6372-1 26 Feb 2021

Consider using TREATMENT_STATE_DATA_T data structure.

HD-DEN-7091-1 28 Feb 2021

Why added?

DG-DEN-5963-1 08 Apr 2021

...operating temperatures between 5 degrees C and 95 degrees C.

DG-DEN-7091-1 01 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5963-1 22 Mar 2021

Align #define values on left.

DG-DEN-5963-1 22 Mar 2021

I thought hot and cold paths got merged into one?

HD-DEN-6200-1 18 Jan 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6453-1 19 Mar 2021

Looks like the function has 250 ms persistence, do we need the TODO anymore?

DG-DEN-6200-1 18 Jan 2021

The dialysate temperature HD sent to DG as another message.

UI-DEN-6349-1 18 Jan 2021

Done

HD-DEN-6200-1 18 Jan 2021

Is this signal indicating start of treatment or proceeding to patient connection? Function name indicates former, conditions indicate latter.

HD-DEN-6200-1 15 Jan 2021

Do we need to broadcast anything during pre-treatment mode? I think sub-mode states are already broadcast elsewhere, but think about any Dialin needs.

HD-DEN-6200-1 18 Jan 2021

Some user actions may depend on which sub-mode or even sub-mode state we are in (e.g. stop or resume would need to be handled if we're priming or re-circulating or doing self tests, but not loading cartridge/disposables). So some signals can be handled here and others will need to be forwarded to the current sub-mode where more context can be assessed.

DG-DEN-6200-1 18 Jan 2021

What parameter is invalid?

UI-DEN-6349-1 13 Jan 2021

This is my comment and it is specific to the exact line below the comment.
Please revert it back to be able to identify which line in the code it refers to.

"This code review includes so many unrelated branched to the code review subject"
look at the list of the commits and branches included in this page
http://dvm-linux02:8060/project/UI-DEN-6349?max=100&projectKey=UI-DEN-6349&view=fe

HD-DEN-7091-1 19 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7091-1 19 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7091-1 19 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-7091-1 19 Mar 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-7091-1 19 Mar 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7091-1 22 Mar 2021

Add fault.

HD-DEN-7091-1 22 Mar 2021

Shouldn't this be an air trap level sensor fault?

HD-DEN-7091-1 22 Mar 2021

Fixed.

HD-DEN-5980-1 22 Feb 2021

Delete this function. Obsolete.

HD-DEN-5980-1 22 Feb 2021

Why is this commented out?

HD-DEN-7091-1 22 Mar 2021

These volumes (4 of them) should be floats so we should add .0 to end of set value.

HD-DEN-7091-1 22 Mar 2021

Valve positions same so pull out of if-else.

HD-DEN-7091-1 22 Mar 2021

If returning a result, should return type be something other than boolean? Maybe SELF_TEST_STATUS_T from Common.h?