This objectName is necessary for the added alarm tests to work, which also guarantees 100% code coverage on my branch It is very helpful for Systems / SW V&V to have as many object names defined so they can write their own squishqt tests In order for Systems / SW V&V to interact with the alarms and so the alarm tests can function, I think it should be kept
If both of these functions are using the same constant, why do we have two functions? Use just one (unless it is planned for them to inherit different constants down the road).
I know these enums are in a header file with "HD" in the name and so the HD_ prefix may seem unnecessary, but I was putting HD_ and DG_ prefixes on mode state enums in case the HD and DG had one or more modes with the same name (like Standby) so there would not be a conflict if somebody wanted to include both HD and DG definitions in there module.
It's not a separate repository it's just a folder in the dialin repository called "tools" Right now this script exists in the root folder when it should reside in the "tools" directory
Sure, I am testing the idea. It's not mature yet. Will complete that and will move in the script repository later and use that for all the three repositories.
Name is too vague. Make it clear this minimum is for occlusion sensors. And also if this minimum applies to narrower scope(s) (like no cartridge or dry or wet) or is it general and should never be less than this?
Some user actions may depend on which sub-mode or even sub-mode state we are in (e.g. stop or resume would need to be handled if we're priming or re-circulating or doing self tests, but not loading cartridge/disposables). So some signals can be handled here and others will need to be forwarded to the current sub-mode where more context can be assessed.
This is my comment and it is specific to the exact line below the comment. Please revert it back to be able to identify which line in the code it refers to.