•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-6349-1 13 Jan 2021

Done

UI-DEN-6349-1 13 Jan 2021

The approach comes from Qt's documentation: It's the QObjectList-based model approach https://doc.qt.io/qt-5/qtquick-modelviewsdata-cppmodels.html, which you can see creates a list of QObject* pointers with values that are accessible as named properties in the qml.
This class has been tested and is working fine
cppcheck doesn't report any errors in this file

UI-DEN-4860-BLE-1 13 Jan 2021

Done - Updated to use iArrow now

UI-DEN-6349-1 08 Jan 2021

Please look at the zeplin, 3.3 Name New Treatment Screen for the text entry UX design.

UI-DEN-6349-1 13 Jan 2021

RESOLVED

UI-DEN-6349-1 13 Jan 2021

RESOLVED

UI-DEN-6349-1 13 Jan 2021

RESOLVED

DG-DEN-6200-1 14 Jan 2021

Added HD_ prefix.

UI-DEN-4860-BLE-1 13 Jan 2021

same

DIALIN-DEN-11250-1 16 Feb 2022

Changed cmd_log_in_to_dg() to cmd_log_in_to_hd()

DG-DEN-5963-1 04 Jan 2021

There should already be an enum for reservoirs somewhere. Use that one.

HD-DEN-5674-2 30 Dec 2020

Fixed.

HD-DEN-9480-1 11 Nov 2021

RESOLVED IN CODE WALKTHROUGH

HD-DEN-5674-2 30 Dec 2020

Fixed.

HD-DEN-5674-2 30 Dec 2020

Fixed.

DG-DEN-5980-1 22 Feb 2021

Why is this commented out?

DG-DEN-6080-1 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4964-1 05 Jan 2021

Addressed.

HD-DEN-9480-1 11 Nov 2021

RESOLVED IN CODE WALKTHROUGH

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-2-1 30 Nov 2020

Dara, rather than referring to another code review, I would just reply that it will be corrected after that code review is completed, branch merged to master, and then master pulled into this branch. Commenter can resolve then at that time when the fix shows up.

DG-DEN-5846-1 30 Nov 2020

Done

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5846-1 30 Nov 2020

This comment is above the for loop. Are you saying it should be above the if statement?

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

Should not (formal) instead of Shouldn't (informal)

DG-DEN-5846-1 30 Nov 2020

The decrease is only 0.005, so we are never less that that and I don't need to check for it.

DG-DEN-5846-1 01 Dec 2020

Persistent alarm now uses time interval limit rather than count. So we do not need to divide by the interval here. This change eliminates the need to know the task interval in which the checking function is getting called.

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5846-1 01 Dec 2020

Done

HD-DEN-4641-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5846-1 30 Nov 2020

Our coding standard says constants s/b all caps with underlines (same as #defines).

DG-DEN-5846-1 30 Nov 2020

100 should be 100.0. If we use this in other places, maybe it can be a common #define.

HD-DEN-5674-2 30 Dec 2020

Fixed.

DG-DEN-5846-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5846-1 30 Nov 2020

This comment should fit on one line.

DG-DEN-5846-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

Fixed.

DG-DEN-5846-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5846-1 30 Nov 2020

Blank line between HALCOGEN #includes and others. Alphabetize #includes in each set.

DG-DEN-5846-1 30 Nov 2020

Persistent alarm has changed to use time period rather than count. Change this to time interval.

DG-DEN-5846-1 30 Nov 2020

Revert this change. Persistent alarm uses time period instead of count.

DG-DEN-5846-1 30 Nov 2020

Use time interval rather than count.

HD-DEN-5674-2 30 Dec 2020

Fixed.

HD-DEN-5674-2 30 Dec 2020

Formalize sentence.

DIALIN-DEN-5674-2 30 Dec 2020

To avoid copying the has_value function into each enum sub-class, it'd be better to make AlarmUserOptions a subclass of DialinEnum, which can be imported from utils/base.py

HD-DEN-5674-2 04 Jan 2021

Add general TODO here then.

UI-DEN-6349-1 08 Jan 2021

Reviewers please note:

According to the qt virtual keyboard technical styling guide, here
it is recommended to use

 Src/qtvirtualkeyboard/src/virtualkeyboard/content/styles/default 

as a base for the custom style. The Qt virtual keyboard styling files (called default and retro) I could find are located here on our VM:

 /opt/Qt5.12.5/5.12.5/Src/qtvirtualkeyboard/src/virtualkeyboard/content/styles/default 


You'll notice that the Qt company has only provided the button images in the svg format. It appears they did this to allow for greater customization of the keyboard styling in the qml code.

I'm aware it has been decided to use pngs in the denali application. If requested, I can change the default Qt-provided keyboard style.qml file to use pngs instead of svgs.
It would be helpful before I do so to get feedback on the look and feel of the numeric keyboard so we have an agreed-upon style, size, and layout of the numeric keyboard, as converting the svgs to pngs will hard-code the styling.

UI-DEN-6349-1 13 Jan 2021

I've added the min/max values for systolic, diastolic, and HR to the Variables.qml file. They come from PRS 451, 452, and 453

UI-DEN-6349-1 12 Jan 2021

The json document holds the information about the BP cuffs we've paired with.
It is also helpful to format the paired device information into json so it can be stored to disk and then re-loaded easily so that we can automatically re-connect to the last selected BP cuff after a reboot.
The dereferencing and casting is needed to work with the ObjectList-based model approach.
All of the slots are there to receive data from the BLEScanner, so we can display available devices to connect to.
We emit signals when we want to connect/reconnect to a device, scan for devices, or request to save the paired devices to disk.