•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-6349-1 13 Jan 2021

Yes, the styling has been updated in the new file

UI-DEN-6349-1 13 Jan 2021

Done

UI-DEN-6349-1 13 Jan 2021

The approach comes from Qt's documentation: It's the QObjectList-based model approach https://doc.qt.io/qt-5/qtquick-modelviewsdata-cppmodels.html, which you can see creates a list of QObject* pointers with values that are accessible as named properties in the qml.
This class has been tested and is working fine
cppcheck doesn't report any errors in this file

UI-DEN-4860-BLE-1 13 Jan 2021

Done - Updated to use iArrow now

UI-DEN-6349-1 08 Jan 2021

Please look at the zeplin, 3.3 Name New Treatment Screen for the text entry UX design.

UI-DEN-6349-1 13 Jan 2021

RESOLVED

UI-DEN-6349-1 13 Jan 2021

RESOLVED

UI-DEN-6349-1 13 Jan 2021

RESOLVED

DG-DEN-6200-1 14 Jan 2021

Added HD_ prefix.

UI-DEN-4860-BLE-1 13 Jan 2021

same

DIALIN-DEN-11250-1 16 Feb 2022

Changed cmd_log_in_to_dg() to cmd_log_in_to_hd()

DG-DEN-5963-1 04 Jan 2021

There should already be an enum for reservoirs somewhere. Use that one.

HD-DEN-5674-2 30 Dec 2020

Fixed.

HD-DEN-9480-1 11 Nov 2021

RESOLVED IN CODE WALKTHROUGH

HD-DEN-5674-2 30 Dec 2020

Fixed.

HD-DEN-5674-2 30 Dec 2020

Fixed.

DG-DEN-5980-1 22 Feb 2021

Why is this commented out?

DG-DEN-6080-1 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4964-1 05 Jan 2021

Addressed.

HD-DEN-9480-1 11 Nov 2021

RESOLVED IN CODE WALKTHROUGH

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6200-1 15 Jan 2021

Done.

DIALIN-DEN-5980-1 25 Mar 2021

RESOLVED.

DG-DEN-3421-2-1 30 Nov 2020

Dara, rather than referring to another code review, I would just reply that it will be corrected after that code review is completed, branch merged to master, and then master pulled into this branch. Commenter can resolve then at that time when the fix shows up.

DG-DEN-5846-1 30 Nov 2020

Done

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5846-1 30 Nov 2020

This comment is above the for loop. Are you saying it should be above the if statement?

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

Should not (formal) instead of Shouldn't (informal)

DG-DEN-5846-1 30 Nov 2020

The decrease is only 0.005, so we are never less that that and I don't need to check for it.

DG-DEN-5846-1 01 Dec 2020

Persistent alarm now uses time interval limit rather than count. So we do not need to divide by the interval here. This change eliminates the need to know the task interval in which the checking function is getting called.

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5846-1 01 Dec 2020

Done

HD-DEN-4641-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5846-1 30 Nov 2020

Our coding standard says constants s/b all caps with underlines (same as #defines).

DG-DEN-5846-1 30 Nov 2020

100 should be 100.0. If we use this in other places, maybe it can be a common #define.

HD-DEN-5674-2 30 Dec 2020

Fixed.

DG-DEN-5846-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5846-1 30 Nov 2020

This comment should fit on one line.

DG-DEN-5846-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

Fixed.

DG-DEN-5846-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5846-1 30 Nov 2020

Blank line between HALCOGEN #includes and others. Alphabetize #includes in each set.

DG-DEN-5846-1 30 Nov 2020

Persistent alarm has changed to use time period rather than count. Change this to time interval.

DG-DEN-5846-1 30 Nov 2020

Revert this change. Persistent alarm uses time period instead of count.

DG-DEN-5846-1 30 Nov 2020

Use time interval rather than count.

HD-DEN-5674-2 30 Dec 2020

Fixed.

HD-DEN-5674-2 30 Dec 2020

Formalize sentence.

DIALIN-DEN-5674-2 30 Dec 2020

To avoid copying the has_value function into each enum sub-class, it'd be better to make AlarmUserOptions a subclass of DialinEnum, which can be imported from utils/base.py

HD-DEN-5674-2 04 Jan 2021

Add general TODO here then.