•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-3421-2-1 12 Nov 2020

That is right. Removed the line.

UI-DEN-5282-1 28 Oct 2020

Objective: #14
This is the dictionary file for the QtCreator spellcheck plugin.

HD-DEN-5674-2 30 Dec 2020

Fixed.

UI-DEN-5282-1 28 Oct 2020

What is this new file for?

UI-DEN-5282-1 29 Oct 2020

RESOLVED.

UI-DEN-7135-1 05 Apr 2021

Not sure I follow the comment you added here, can you clarify?

DG-DEN-3421-2-1 17 Nov 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-5282-1 28 Oct 2020

Objectives: #01, #04
Because of the new standard message (#01) I could be able to use my notify template function (#04) and then these codes are not used anymore.

UI-DEN-5282-1 28 Oct 2020

What is this new file for?

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-5282-1 28 Oct 2020

Objectives: #01
Because of the new standard message (#01) I could be able to use the FW's returned reason filed for the new message which the old one didn't have.
So removed UI handling of the message rejection reason by the FW one as designed by standard Response messages.

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7395-1 11 Apr 2021

I suppose this is not the monitor function and it is the exec function?

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7395-1 12 Apr 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5855-1 30 Nov 2020

And also revert spacing in function code below.

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

Done.

HD-DEN-7395-1 12 Apr 2021

Addressed.

HD-DEN-5674-2 30 Dec 2020

Done.

DG-DEN-5864-1 30 Nov 2020

And 2 other params missing here.

DG-DEN-5846-1 30 Nov 2020

Done.

HD-DEN-5674-2 30 Dec 2020

Done.

HD-DEN-5674-2 30 Dec 2020

Fixed.

DG-DEN-5846-1 30 Nov 2020

I aligned them.

DG-DEN-5846-1 30 Nov 2020

Done. I will cast them.

DG-DEN-5846-1 30 Nov 2020

Done. I will cast it.

HD-DEN-5674-2 30 Dec 2020

Fixed.

HD-DEN-4641-1 30 Nov 2020

Done.

DG-DEN-5846-1 30 Nov 2020

Done

UI-DEN-4964-1 03 Jan 2021

RESOLVED

DG-DEN-5846-1 30 Nov 2020

Done

HD-DEN-5674-2 30 Dec 2020

Formalize sentence.

DG-DEN-5846-1 30 Nov 2020

Done

DG-DEN-5846-1 30 Nov 2020

Done

HD-DEN-4641-1 30 Nov 2020

Done.

DG-DEN-5846-1 30 Nov 2020

Done

DG-DEN-5846-1 30 Nov 2020

Why only a maximum speed? I would think a minimum speed would be more important.

DG-DEN-5846-1 30 Nov 2020

This function should probably be called at top of monitor function.

DG-DEN-5846-1 30 Nov 2020

Add "_STATE" to end of each enum name.

DG-DEN-5846-1 30 Nov 2020

Fix comment - s/b PWM duty cycle %.

DG-DEN-5846-1 30 Nov 2020

Why is bit count declared like a floating point?

DG-DEN-5846-1 30 Nov 2020

Other broadcast functions appear to be grouped above.

DG-DEN-5864-1 30 Nov 2020

Not indented with other fields.

DG-DEN-5855-1 30 Nov 2020

Add a TODO on this.

DG-DEN-5855-1 30 Nov 2020

Why removed?

DG-DEN-5855-1 30 Nov 2020

I don't see any inputs to this function. Why change from none?

UI-DEN-5830-2 13 Jan 2021

RESOLVED

DG-DEN-5855-1 09 Dec 2020

RESOLVED in CODE WALKTHROUGH.