•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 26 Oct 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

????? are for what? Can we add definition here?

HD-DEN-15306-3 02 Jun 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4691-1 16 Nov 2020

RESOLVED

DG-DEN-3504-1 16 Nov 2020

There may be a need to run these pumps in forward or reverse direction (heat disinfect mode). And this would not be tied to RO flow rate - we would want to set an independent flow. May also want to control the pumps independently in this mode.

UI-DEN-4964-1 03 Jan 2021

Addressed.

DIALIN-DEVELOP-BUG-FIXES-1 17 Nov 2020

RESOLVED.

DG-DEN-3421-2-1 17 Nov 2020

Why indentation?

UI-DEN-5777-1 01 Feb 2021

RESOLVED.

DG-DEN-5846-1 30 Nov 2020

Done

DG-DEN-5846-1 30 Nov 2020

Done

UI-DEN-4964-1 03 Jan 2021

Please change it to "HDAccelData" as you have stated in the infoText function. this should be exactly the text user may search for in the log file to find the logged message.

DG-DEN-3421-2-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5846-1 30 Nov 2020

We need to set fpga error to 0 to bypass incorrect error count from FPGA. Otherwise, there will be temperature sensor fault alarm sending to HD once DG is running.

DIALIN-DEN-5751-1 01 Feb 2021

will be addressed later,
RESOLVED

HD-DEN-5674-2 04 Jan 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 04 Jan 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5846-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5846-1 30 Nov 2020

Remove extra line.

DG-DEN-5846-1 30 Nov 2020

Bit count will never be fractional. Should declare as integer (4096). If using in a floating point operation, cast it as (F32).

DG-DEN-5846-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5846-1 30 Nov 2020

Remove extra blank line.

DG-DEN-5846-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5846-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5855-1 30 Nov 2020

Why include twice?

DG-DEN-5873-1 30 Nov 2020

Function name implies a boolean return value. Why U32?

DG-DEN-5873-1 30 Nov 2020

Override handlers (and really any handlers for messages that would only come from Dialin) should have the word Test in the name to help distinguish Dialin test functions from other f/w functions.

DG-DEN-5846-1 09 Dec 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4964-1 05 Jan 2021

Addressed.

DG-DEN-5846-1 09 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-5674-2 06 Jan 2021

Done.

UI-DEN-6349-1 08 Jan 2021

On 1.8.2021:
Code Coverage: 100%
SquishQt Tests: 100% passing

UI-DEN-5830-2 13 Jan 2021

RESOLVED

UI-DEN-4860-BLE-1 12 Jan 2021

QObject has a built-in time.
override the :
void <class>::timerEvent(QTimerEvent *)
\sa MainTimer

UI-DEN-6349-1 13 Jan 2021

Done

UI-DEN-4860-BLE-1 13 Jan 2021

This folder contains treatment related information such as parameter ranges as well as paired BLE devices.
Would you prefer we store the bluetooth devices in a separate folder called bluetooth instead?

UI-DEN-6349-1 13 Jan 2021

RESOLVED

UI-DEN-6349-1 13 Jan 2021

RESOLVED

UI-DEN-4860-BLE-1 13 Jan 2021

Done

UI-DEN-4860-BLE-1 13 Jan 2021

Why this specific dialog has been created and not NotificationDialog used and what is special about that?
Please provide a screenshot to compare.

UI-DEN-4860-BLE-1 12 Jan 2021

same

UI-DEN-6349-1 13 Jan 2021

refer to the above comment about the MainTimer.

UI-DEN-6349-1 13 Jan 2021

Why this is imported?

DG-DEN-3421-1 26 Oct 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4598-1 29 Oct 2020

Please rename the file to MTreatmentEndResponse

DG-DEN-5855-1 10 Dec 2020

Missing param name.

HD-DEN-14344-3 23 Nov 2022

Fixed. Thanks!

UI-DEN-5282-1 28 Oct 2020

Objective: #14
This is the dictionary file for the QtCreator spellcheck plugin.