•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-3421-2-1 14 Nov 2020

Done

UI-DEN-4860-BLE-1 30 Dec 2020

As of today, 12.30.2020:
Code Coverage: 100%
SquishQt tests: 100% passing
Unit Tests: 100% passing

UI-DEN-5777-1 01 Feb 2021

RESOLVED.

DG-DEN-5846-1 30 Nov 2020

Done

UI-DEN-4964-1 03 Jan 2021

RESOLVED

DG-DEN-3421-2-1 17 Nov 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-8030-1 16 Jun 2021

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5846-1 30 Nov 2020

Ok. I am not sure if git will like this. Done.

UI-DEN-5751-1 01 Feb 2021

will be addressed later,
RESOLVED

DG-DEN-8030-1 16 Jun 2021

do we need to resolve this conflict?

HD-DEN-4641-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5846-1 30 Nov 2020

Done

DG-DEN-7091-1 28 Feb 2021

Why removed?

DG-DEN-5846-1 30 Nov 2020

I have been changing all the PWM to duty cycle, I just didn't see this one.

UI-DEN-5830-2 12 Jan 2021

Thanks for catching that. Fixed.
This script is helping to have a summary of the objectives in the code reviews and a summary of what has been done in this branch.

HD-DEN-4641-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-7091-1 28 Feb 2021

Remove extra line.

DG-DEN-5846-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5846-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5846-1 30 Nov 2020

Add "_STATE" to end of each enum name and "state" to end of each comment.

UI-DEN-6349-1 13 Jan 2021

Done

DG-DEN-5846-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5846-1 30 Nov 2020

Add "states" to end of comment.

DG-DEN-5846-1 30 Nov 2020

Move these init functions up in order with other controller/monitor init functions.

DG-DEN-5855-1 30 Nov 2020

Do we need this check if there is range check inside the function setDrainPumpTargetRPM?

DG-DEN-5846-1 30 Nov 2020

Why is this else (decreasing) not symmetric with increasing condition above?

DG-DEN-5873-1 30 Nov 2020

For consistency, be explicit when checking boolean conditions (as done below in this function). Include TRUE ==.

DG-DEN-5846-1 09 Dec 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-5830-2 13 Jan 2021

RESOLVED

DG-DEN-5855-1 10 Dec 2020

Done

DIALIN-DEN-5830-2 13 Jan 2021

Unused import

UI-DEN-4860-BLE-1 13 Jan 2021

Done

UI-DEN-4860-BLE-1 13 Jan 2021

This isn't a change I had made.
You added this in cd769413344091cea88a30861b49188c8c147cba
I don't know why it's showing up here. Seems like crucible messed up
Do you want me to remove it anyway?

UI-DEN-4860-BLE-1 13 Jan 2021

Having a separate component prevents alerts from covering up alarms and ensures the alarm takes precedence

UI-DEN-6349-1 13 Jan 2021

acceptableInput is a property of the TextInput component.
The TextInput component in TextEntry is accessed via the textInput alias

UI-DEN-4860-BLE-1 18 Jan 2021

RESOLVED

DG-DEN-3504-1 12 Nov 2020

Changed variable name and added units in comment.

DG-DEN-3421-1 26 Oct 2020

Don't see any change here.

DG-DEN-5963-1 13 Apr 2021

Done.

HD-DEN-4640-1 26 Oct 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4691-1 15 Nov 2020

Removed.

DG-DEN-5963-1 04 Jan 2021

Change to resEmpty.

HD-DEN-4640-1 26 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 26 Oct 2020

This looks like a merge issue. I see duplicate build switches.

UI-DEN-4691-1 15 Nov 2020

Done

DG-DEN-3421-1 26 Oct 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 26 Oct 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-5751-1 01 Feb 2021

It is noted.
Since this is part of the Arterial/Venous pressure feature and not the preTx_Uf, will be taking care of it as part of the code clean-up and integration I need to do later.
By the way, it's not my solution and not even my approved one.

DG-DEN-3421-1 26 Oct 2020

RESOLVED in CODE WALKTHROUGH.