Comment Search

That is right. Changed to AND.

RESOLVED in CODE WALKTHROUGH.

Again, doesn't make sense to assign a delta % to a %.
If candidate PWM duty cycle % is decreasing, need the same logic as above with increase to ensure you don't exceed max decrement. As I understand it, a decrease is more important when considering how quickly the fan speed should be allowed to change.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Not a big fan of numbering variables like Speed1, Speed2, etc.

Remove extra space between U32 and function name.

I agree, but I wanted to keep this naming consistent with Tx, Uf only in two letters.

Move up in order with other inits for controllers/monitors.

I've noted this and will make sure to resolve it later

No. This function gets the deltaP, sets the pump control to closed loop and set the closed loop flag to TRUE. In the off state, the minimum DAC is set to 300 RPM and from there the PI controller will take over.

Should not (formal) instead of Shouldn't (informal)

Merge issue. Reverse the change.

RESOLVED in CODE WALKTHROUGH.

Validate given reactor before using it.

RESOLVED IN CODE WALKTHROUGH

we are (formal) instead of we're (informal)

I think this local variable is poorly named. Looking below, it appears to be a pulse count from FPGA.
If it is a pulse count, I don't know about the term "toggle" for describing it.

RESOLVED in CODE WALKTHROUGH.

Sean isn't this part of the request in DIAL-2 - Set Operation Modes? Maybe we should discuss

I don't understand this equation. If slope converts temp to PWM duty cycle % (which is what you want), why do we need the min % and min temp terms?

Update @params to match function parameters.

Move code below declarations.