•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-5846-1 30 Nov 2020

Yes. I put at the top of this function. Because there are only two states and most of times we are running the fans. I also did not want to monitor the fans every 50ms so I put it here to monitor the fans whenever it is time to control the fans.

DG-DEN-5846-1 30 Nov 2020

I didn't realize we have this in common.h. I used that.

DG-DEN-5846-1 30 Nov 2020

This showed in the merge. I will test them in the lab and remove the comments.

DG-DEN-5846-1 30 Nov 2020

Done

HD-DEN-4641-1 30 Nov 2020

Fixed.

HD-DEN-4641-1 30 Nov 2020

Fixed.

DG-DEN-5846-1 30 Nov 2020

Done

DG-DEN-5846-1 30 Nov 2020

Done

HD-DEN-4641-1 30 Nov 2020

Done.

DG-DEN-5846-1 30 Nov 2020

Now added them.

DG-DEN-5864-1 30 Nov 2020

Should payload is F32 rather than TEST_OVERRIDE_PAYLOAD_T?

DG-DEN-5864-1 30 Nov 2020

I don't think this call will work anymore. Need to set to a flow.

DG-DEN-5864-1 30 Nov 2020

I think we can create preliminary #defines now. 0.8 L is likely what we want. Control limit can probably go up to 130. Max is still 140, but not relavant to this line of code.

DG-DEN-5855-1 30 Nov 2020

If changing function name, change name in function header as well.

HD-DEN-7395-1 08 Apr 2021

Can these two publish functions be lumped together?

HD-DEN-5053-1 20 Oct 2020

Done.

HD-DEN-5674-2 30 Dec 2020

Done.

DG-DEN-3421-1 19 Oct 2020

Once I am close to finishing this story, I will go over the doxygen documentation to make sure it is up to date. Please resolve this comment. I will address all the doxygen comment in the next Heat Disinfection code review.

HD-DEN-4640-1 20 Oct 2020

Why one flow is in percent and the other in per unit? (which requires conversion)

DG-DEN-3421-1 26 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 26 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 26 Oct 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-5282-1 28 Oct 2020

Why removed?

HD-DEN-5674-2 30 Dec 2020

Should not (formal) instead of Shouldn't (informal)

DG-DEN-3421-2-1 10 Nov 2020

I know I made this change when helping you troubleshoot drain pump control, but looking at this again, I think we need both options for calculating the error signal (depending on which control is in play). I'm concerned that this change may damage some/all of the other controls.

UI-DEN-4598-1 10 Nov 2020

Done

DG-DEN-3504-1 10 Nov 2020

Renamed to indicate micro-steps per step.

DG-DEN-3504-1 10 Nov 2020

Done.

DG-DEN-3421-2-1 13 Nov 2020

Done

UI-DEN-4691-1 10 Nov 2020

done

DIALIN-DEN-4691-1 10 Nov 2020

done

UI-DEN-4598-1 10 Nov 2020

RESOLVED

UI-DEN-4598-1 10 Nov 2020

RESOLVED
http://dvm-linux02:8080/browse/DEN-5642

DIALIN-DEN-4691-1 10 Nov 2020

RESOLVED.

DG-DEN-3421-2-1 13 Nov 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-5328-1 11 Nov 2020

RESOLVED

DIALIN-DEN-5328-1 11 Nov 2020

Add space between functions.

DG-DEN-3504-1 12 Nov 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3504-1 12 Nov 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3504-1 12 Nov 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3504-1 12 Nov 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3504-1 10 Nov 2020

Add units to step speed in comment. Steps per step period? Step period is 0.5 uSec?

DG-DEN-3504-1 12 Nov 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-2-1 12 Nov 2020

This is exec state of each reactor and it cannot be overridden. The Dialin user will be able to turn on and off the UV reactors but not override them.

DG-DEN-3421-2-1 10 Nov 2020

Remove blank line.

DG-DEN-3421-2-1 12 Nov 2020

Removed the override variable completely.

DG-DEN-3421-2-1 12 Nov 2020

Two of the items are reactor specific. I initialized the rest of them in a loop.

DG-DEN-3421-2-1 12 Nov 2020

Done

DG-DEN-3421-2-1 10 Nov 2020

Floating point literals should always have a decimal point. Change 0 to 0.0.

DG-DEN-3421-2-1 12 Nov 2020

Rephrased the sentence.