Done
RESOLVED in CODE WALKTHROUGH.
RESOLVED IN CODE WALKTHROUGH
Add units in comment between parentheses.
Why is this called "valveData"?
Fixed.
It is initialized inside function stopConcentratePump().
Revert this change.
RESOLVED. OK, I will rename these two. For new functions in the future please keep them consistent with the other dialin codebase and PEP8.
For dialysate mixing, I do not see a use case where one pump is on and the other pump is off.
Done.
we are (formal) instead of we're (informal)
Once the user has selected the arterial and venous pressure limits in pre-treatment, before they try to adjust them, how are the values they chose in pre-treatment displayed here?
Removed the function.
Changed (2 x 0.25) to 0.5 and indicated 0.5 us is the step period resolution.
Thanks for reminding that. updated all the other ones as well. done.
Rename function to ...PumpsOff().
Yes, it is, but with none of my concerns dealt with. It will not be this simple.
Remove empty lines.
Floating point equation - literals should have a decimal point.
Do we need this check if there is range check inside the function setDrainPumpTargetDeltaPressure?
Generally, we have two lines before and after this comment to separate test functions and normal code.
Missing param name.
isSalineBolusInProgress is clearer
Why is temperature published so frequently? Was 1 Hz really too slow?
Looks like a lot of trouble to align these parameters, and still not aligned.
Change name to getMeasuredFanRPM() to distinguish commanded speed from measured speed (even though there is no commanded speed in this case).
Our coding standard says constants should be named with all caps and underlines (same as #define).
And also revert spacing in function code below.
Is there a better place to put this note? Maybe in a function header brief where it is used?
What does this comment mean?
Monitor call(s) should probably be made at top of exec so monitoring takes place in all states.
This part of test only makes sense for POST. If we want to re-run this test before each treatment, we would fail this I think.
Keep the word "Test" in these Dialin message handling functions.
Add blank line between declarations and code.
The case is outside the #ifdef, so the break should be as well (or vice-versa).
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
