Function has been removed.
Fixed.
This should be a separate if. Otherwise, this else if is not reachable.
RESOLVED in CODE WALKTHROUGH.
RESOLVED
we will (formal) instead of we'll (informal)
Done.
Done
As implemented, I don't think you should set this flag to false. Will cause it to turn off immediately once in ON state.
Fixed the the statement.
I think we should only use primary load cell (not redundant) for these types of determinations. Redundant load cell is just for safety.
Before this "if", I think you should verify pwm is within min/max range (0.1 to 0.95) and cap if out of range.
Formalize sentence.
incorrect comment line has been changed. please revert back "Datum" and change the infoText section.
Should these two pins (enable output and health input) be something that can be overridden? I would think at least the input health pin should be.
Provide comment as to why Bank 7 Sector 0 is used here.
Move comment outside of if statement.
Related testsuites review: http://dvm-linux02:8060/cru/#UI-DEN-5638-1CFR-20510
Why indentation?
Please refer to DEN-5864 code review.
Please refer to DEN-5846 code review.
Consider converting targetBloodFlowRate to non-override type and remove get function.
Consider converting targetDialInFlowRate to non-override type and remove get function.
change 0xCCC33C33 to OVERRIDE_KEY.
same as above comment.
We might need to obtain absolute value here to account for negative error when current flow is higher than target flow.
Align the last line. Should these number be defined?
The values come from the datasheets of the sensors.
5//10 ?
If it was necessary to rename Saline_States to Saline_Bolus_States, shouldn't you rename GuiSalineStates to GuiSalineBolusStates as well?
Add "?"
we have (formal) instead of we've (informal)
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
