•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-5674-2 30 Dec 2020

Should not (formal) instead of Shouldn't (informal)

HD-DEN-5674-2 30 Dec 2020

Fixed.

HD-DEN-5674-2 30 Dec 2020

there is (formal) instead of there's (informal)

DG-DEN-3504-1 12 Nov 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3504-1 10 Nov 2020

Fix spelling error (increment). Is this a maximum increment? If so, change name and add to comment.

DG-DEN-3504-1 10 Nov 2020

Add decimal point to literals that will be used in floating point equations.

DG-DEN-3421-2-1 10 Nov 2020

This comments doesn't make sense.

HD-DEN-5674-2 30 Dec 2020

Fixed.

DG-DEN-3421-2-1 13 Nov 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-2-1 21 Nov 2020

Done

UI-DEN-4691-1 10 Nov 2020

To make it consistent these could also be red and white without double quotes

HD-DEN-5674-2 30 Dec 2020

Should not (formal) instead of Shouldn't (informal)

DG-DEN-3421-2-1 29 Nov 2020

Please refer to DEN-5846 code review.

HD-DEN-5887-1 30 Dec 2020

RESOLVED in CODE WALKTRHOUGH.

HD-DEN-5674-2 30 Dec 2020

we have (formal) instead of we've (informal)

HD-DEN-5674-2 30 Dec 2020

Do not (formal) instead of Don't (informal)

DG-DEN-3421-2-1 21 Nov 2020

There are 6 fans. Three inlet and three outlet. They are controlled as if there are only two fans, meaning 1 duty cycle will be fed to inlet fans and 1 duty cycle will be fed to the outlet fans. The only time that are treated individually is when we read their RPM. That is why I called them inlet 1, 2.

HD-DEN-5674-2 30 Dec 2020

we are (formal) instead of we're (informal)

HD-DEN-4641-1 23 Nov 2020

same as above comment.

DG-DEN-5846-1 09 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-2-1 23 Nov 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-2-1 17 Nov 2020

What is extra line for?

DG-DEN-3421-2-1 23 Nov 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-2-1 23 Nov 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-5638-1 24 Nov 2020

Related dialin code review: http://dvm-linux02:8060/cru/DIALIN-DEN-5638-1

HD-DEN-4641-1 23 Nov 2020

The condition of if statement can be passed directly into second parameter of checkPersistentAlarm function.
This will remove the need for if and else.

DG-DEN-5846-1 07 Dec 2020

Done

DG-DEN-5846-1 07 Dec 2020

Done

DG-DEN-5864-1 09 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5864-1 09 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5846-1 09 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 10 Aug 2020

Same comment as Drain pump. Keep the "Set" variabl. roPumpControlMode would be set by the "Set" function. roPumpControlModeSet would be set by the state machine when the requested mode is actually set.

DG-DEN-3421-1 20 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3504-1 12 Nov 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-5283-1 20 Oct 2020

RESOLVED.

DG-DEN-3421-1 20 Oct 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

Fixed.

UI-DEN-5283-1 20 Oct 2020

RESOLVED

UI-DEN-4964-1 20 Oct 2020

RESOLVED.

DG-DEN-3421-2-1 13 Nov 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-5751-1 01 Feb 2021

Removed.

DG-DEN-3421-1 22 Oct 2020

Created #defines to convert min and maximum RPMs to DACs.

DG-DEN-3421-1 26 Oct 2020

That is right. The pump is already is set. I removed the code.

HD-DEN-7395-1 12 Apr 2021

Addressed.

DG-DEN-3504-1 10 Nov 2020

Done.

DG-DEN-3504-1 10 Nov 2020

Done.

DG-DEN-3504-1 10 Nov 2020

Consider moving this function to common Utilities module. Could be shared by other modules.

HD-DEN-4640-1 26 Oct 2020

Structure fields are a mix of different sizes. Compiler will put each field in 32-bit space and pad by default. Since we will be serializing this data for transmission, we do not want structure to include any padding. The pack pragma instructs compiler not to pad.

HD-DEN-4640-1 26 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 26 Oct 2020

RESOLVED in CODE WALKTHROUGH.