•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-3421-1 20 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 20 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 20 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 20 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 12 Aug 2020

Dangerous way of putting parentheses, are you calling function on the numerator only?

DG-DEN-3421-1 20 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 12 Aug 2020

Remove commented line (if still needed, add a TODO with explanation why it is there)

DG-DEN-3421-1 20 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 12 Aug 2020

There are no spaces between function name and first parenthesis, please fix throughout code.

DG-DEN-3421-1 20 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 20 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 12 Aug 2020

There are no spaces between function name and first parenthesis, please fix throughout code.

DG-DEN-3421-1 20 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 12 Aug 2020

There are no spaces between function name and first parenthesis, please fix throughout code.

DG-DEN-3421-1 20 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 20 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 20 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 12 Aug 2020

Align Doxygen comments.

DG-DEN-3421-1 20 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 20 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 12 Aug 2020

Align Doxygen comments.

DG-DEN-3421-1 20 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 12 Aug 2020

Align Doxygen comment

HD-DEN-5053-1 20 Oct 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4964-1 20 Oct 2020

RESOLVED

DG-DEN-3421-1 26 Oct 2020

That is right, they are already set. I removed the pump.

DIALIN-DEN-11980-1 16 Feb 2022

RESOLVED.

DG-DEN-3421-1 20 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5855-1 07 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 20 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-5283-1 20 Oct 2020

RESOLVED.

DG-DEN-5846-1 07 Dec 2020

Done

DG-DEN-3421-1 26 Oct 2020

That is correct they are already set. I removed the code.

DG-DEN-5873-1 02 Dec 2020

This check is not needed since turn on/off function already check for valid reactor index.

DG-DEN-5846-1 07 Dec 2020

Mismatch function name.

DG-DEN-3421-1 26 Oct 2020

Ok sure. I set drainPumpDAC here.

DG-DEN-3421-2-1 07 Dec 2020

SELECTD is misspelled.

DG-DEN-3421-1 26 Oct 2020

I added the checks.

DG-DEN-3421-1 26 Oct 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4598-1 09 Nov 2020

Please be consistent with the other screens objectName.
In terms of using '_' underscore an also camelCase and using "Treatment" word location in the name.
This should be _treatmentCreateFlickable regarding your previous usage in TreatmentBegin.qml.

HD-DEN-4641-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4641-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

Add "?" at end of question comment.

HD-DEN-5674-2 30 Dec 2020

we have (formal) instead of we've (informal)

UI-DEN-5751-1 01 Feb 2021

will be addressed later,
RESOLVED

UI-DEN-4964-1 29 Dec 2020

Addressed.

UI-DEN-4964-1 12 Jan 2021

Please remove if not used.

DG-DEN-5855-1 03 Dec 2020

Done

UI-DEN-5736-1 03 Dec 2020

RESOLVED.

DG-DEN-5855-1 03 Dec 2020

We do check inside that function and raise an alarm if needed. But for Dialin we check in the function too so if the RPM is out of range, it will return a FALSE rather than raising an alarm.