•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-5873-1 09 Dec 2020

Done

UI-DEN-6349-1 12 Jan 2021

Zero works too. I've updated it to zero

DG-DEN-3421-2-1 09 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5855-1 10 Dec 2020

Done

UI-DEN-6349-1 12 Jan 2021

It still applied to the newly created file.

DG-DEN-5855-1 10 Dec 2020

Done

DG-DEN-5855-1 10 Dec 2020

Done

UI-DEN-4860-BLE-1 12 Jan 2021

same

UI-DEN-5830-2 12 Jan 2021

Shouldn't this be declared last?

UI-DEN-6349-1 12 Jan 2021

Space between functions.

UI-DEN-5830-2 12 Jan 2021

Can be deleted

UI-DEN-6349-1 08 Jan 2021

please a complete argument (const TYPE &vArgument)

UI-DEN-5830-2 12 Jan 2021

Was this added by mistake?

UI-DEN-5830-2 12 Jan 2021

Can delete

HD-DEN-5053-1 19 Oct 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 29 Dec 2020

Added TODO instead.

HD-DEN-4640-1 19 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 12 Aug 2020

Make it a one liner

DG-DEN-3421-1 19 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 19 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 19 Oct 2020

I am dividing the elapsed time in ms to MINUTE_TO_MS_CONVERSION = 60000 to convert the value back to minutes to be reported out. This #define is also used to convert minutes to ms by adding the value to this #define.

DG-DEN-3421-1 19 Oct 2020

Done

DG-DEN-3421-1 19 Oct 2020

Done

DG-DEN-3421-1 19 Oct 2020

Fixed them throughout the entire code.

DIALIN-DEN-5283-1 19 Oct 2020

The comparison to None should be

if vSecsRem is None: 
DG-DEN-3421-1 19 Oct 2020

Fixed them throughout the entire code.

DG-DEN-3421-1 19 Oct 2020

Fixed them throughout the entire code.

DG-DEN-3421-1 19 Oct 2020

The ramp up stage is only an I controller. The final stage is a PI controller.

DG-DEN-3421-1 19 Oct 2020

Fixed them throughout the entire code.

DG-DEN-3421-1 19 Oct 2020

This is the integer value of the that enum. The values of displayed as a comment every 5 enums.

DG-DEN-3421-1 19 Oct 2020

Fixed them throughout the entire code.

UI-DEN-5283-1 20 Oct 2020

RESOLVED

DG-DEN-3421-1 19 Oct 2020

Added stop primary and trimmer heaters.

DG-DEN-3421-1 19 Oct 2020

Uncommented the alarm.

DG-DEN-3421-1 19 Oct 2020

Could you please elaborate more?

DG-DEN-3421-1 19 Oct 2020

I brought back the functionality.

DG-DEN-3421-1 19 Oct 2020

Brought the variable back.

DG-DEN-3421-1 19 Oct 2020

Brought back the capability.

DG-DEN-3421-1 19 Oct 2020

Removed the fabs.

DG-DEN-3421-1 19 Oct 2020

Bought back the variable.

UI-DEN-5283-1 19 Oct 2020

in Qml codes when needs to have private members since we don't have that concept, a QtObject item with id "_private" will be created.
"_" is for private and private is to emphasis on the private since there is no actual private keyword in Qt<6 available.
And there should be a unique one in each context.

DG-DEN-3421-1 19 Oct 2020

Done

DG-DEN-3421-1 19 Oct 2020

Spoke with Sean, uncommented the alarm.

UI-DEN-5283-1 19 Oct 2020

done.

UI-DEN-5283-1 19 Oct 2020

Better to not use global variables unless absolutely necessary

DG-DEN-3421-1 20 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 20 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 20 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 20 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 11 Aug 2020

why alarm is commented out?