•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-3504-1 10 Nov 2020

Done. This is not a maximum increment.

DG-DEN-6080-1 29 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5873-1 01 Dec 2020

The function gioGetBit returns a U32 so I made the function be a U32. I changed it to a BOOL.

DG-DEN-6080-1 29 Dec 2020

Assume this is 10% (not 0.1%), so not technically a percent.

DG-DEN-3504-1 10 Nov 2020

Putting local declaration at top of function will remove the const. Should we allow this type of declaration where variable is closest to the location it is being used?

DG-DEN-6080-1 29 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3504-1 10 Nov 2020

Done.

HD-DEN-5381-1 17 Dec 2020

Where did command to start reservoir 2 as active get moved to?

DIALIN-DEN-4691-1 10 Nov 2020

done

DG-DEN-6080-1 29 Dec 2020

Start comment with capital letter for consistency with the other lines.

DIALIN-DEN-5328-1 11 Nov 2020

Done

DG-DEN-6080-1 29 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5873-1 07 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-2-1 11 Nov 2020

That is right, I changed it.

HD-DEN-5381-1 29 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3504-1 12 Nov 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3504-1 10 Nov 2020

I would think you would need this to be an array (one element for each reservoir) so that you can clear request for each when tare is completed.

DG-DEN-3504-1 12 Nov 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3504-1 10 Nov 2020

Should this conversion from float to U16 be rounded instead of floored for better accuracy?

HD-DEN-5674-2 29 Dec 2020

These build switches are meant to be commented out at times - that is how the switch is turned off.

HD-DEN-4641-1 01 Dec 2020

Done.

HD-DEN-4641-1 01 Dec 2020

Done.

UI-DEN-5736-1 02 Dec 2020

Basically, you're calling waitForObjectExists on a component that will always exist. It will be visible and enabled too, so waitForObject wouldn't help you. What would help you is to wait for the object to exist that distinguishes it from the object being waited for in previous calls to test_state. The dictionary, names.o_treatmentStart_HeparinSection, is not unique with each call, but if you set the buttonText property of that dictionary on each call, then it will be unique. So that property needs to be part of the object you're waiting for in order for repeated calls to waitForObjectExists to be useful. Using the helper function is up to you. I'm just letting you know of its existence and purpose should you choose to use it in the future once it's merged. Hope this clarifies things

DG-DEN-6080-1 29 Dec 2020

I added a persistent alarm for it.

HD-DEN-4641-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4641-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4641-1 01 Dec 2020

Did we decide to separate the HALCoGen includes from the internal includes?

DG-DEN-6081-1 29 Dec 2020

Done

DG-DEN-5864-1 02 Dec 2020

Done

DG-DEN-5864-1 02 Dec 2020

Done

HD-DEN-5887-1 30 Dec 2020

Should we associate primary load cell reading to each reservoir and run a for loop here?

DG-DEN-5864-1 02 Dec 2020

Done

DG-DEN-5864-1 02 Dec 2020

Yes it is an F32. I fixed it.

UI-DEN-5736-1 01 Dec 2020

"change" instead of "chane", also replace "I'm" with "I am", basically no informal language in code comments, only formal language.

HD-DEN-5674-2 30 Dec 2020

we are (formal) instead of we're (informal)

UI-DEN-5736-1 03 Dec 2020

RESOLVED

DG-DEN-5873-1 30 Nov 2020

I think condition should stay. Flag name is confusing. hasTurnOnBeenRequested sounds like it only relates to turning UV reactor on but it's not. Setting to FALSE indicates we want UV reactor turned off. Recommend renaming this flag.

DG-DEN-5855-1 07 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5855-1 07 Dec 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-5830-2 12 Jan 2021

removed.

UI-DEN-4860-BLE-1 13 Jan 2021

See response above

UI-DEN-4860-BLE-1 13 Jan 2021

See response above

UI-DEN-4860-BLE-1 13 Jan 2021

See response above

DIALIN-DEN-5830-2 13 Jan 2021

RESOLVED

UI-DEN-6349-1 13 Jan 2021

When I removed the keyboard styling I removed this variable as well

UI-DEN-6349-1 13 Jan 2021

RESOLVED

UI-DEN-6349-1 13 Jan 2021

This is your change actually. It looks like you added this in 45ce6e78
The alarm colors won't work without it

UI-DEN-4598-1 09 Nov 2020

Later please change the class name to MTreatmentStartResponse (Treatment after M and Start After Treatment).

DG-DEN-5855-1 10 Dec 2020

Should we allow 1.0 LPM if that is the defined MAX?

HD-DEN-4641-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.