•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-7395-1 12 Apr 2021

Addressed.

DIALIN-DEN-4690-1 14 Oct 2020

RESOLVED

UI-DEN-4690-1 14 Oct 2020

RESOLVED.

UI-DEN-4690-1 14 Oct 2020

RESOLVED.

UI-DEN-4598-1 03 Nov 2020

Done

UI-DEN-4690-1 14 Oct 2020

Fair, not related to story.

RESOLVED.

UI-DEN-4690-2-1 30 Sep 2020

Which of these classes will need to be in the production code?

VDGROPump
VDGDrainPump
VDGPressures
VDGReservoir
VDGHeaters
VDGLoadCellReadings
VDGTemperatures
VDGValveStates
VDGOperationMode
VTreatmentBloodFlow
VTreatmentDialysateFlow
VTreatmentUltrafiltration
VTreatmentPressureOcclusion


Are any only for in-development testing / convenience for systems?

UI-DEN-4690-2-1 14 Oct 2020

RESOLVED

UI-DEN-4690-2-1 14 Oct 2020

RESOLVED.

Fair, not related to story

UI-DEN-3605-4 30 Sep 2020

Good idea but not a correct macro.
There should be a macro to identify if you build for iMX8 or desktop 64 bit because you can have both Release or Debug on both platforms and this doesn't serve the purpose.

UI-DEN-3605-4 14 Oct 2020

RESOLVED

UI-DEN-4598-1 04 Nov 2020

Done

UI-DEN-3605-4 14 Oct 2020

I have found a way to test this without using QThread. So, QThread has been removed

UI-DEN-4598-1 04 Nov 2020

Done

UI-DEN-3605-4 14 Oct 2020

Done

UI-DEN-4598-1 04 Nov 2020

Done

TESTSUITES-DEN-3724-1 14 Oct 2020

Done

UI-DEN-4598-1 04 Nov 2020

Done

TESTSUITES-DEN-3724-1 14 Oct 2020

Done

UI-DEN-4598-1 09 Nov 2020

RESOLVED

UI-DEN-3605-4 15 Oct 2020

RESOLVED.

DG-DEN-3421-1 19 Oct 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4598-1 03 Nov 2020

Please put the message document for this class as well and all the other model classes.

UI-DEN-3605-4 15 Oct 2020

RESOLVED.
As we talked it should be changed to released(var vMouseEvent) signal and will be emitted in the onReleased{} slot of the MouseArea of RangeRect.

UI-DEN-3605-4 15 Oct 2020

RESOLVED

UI-DEN-4598-1 09 Nov 2020

RESOLVED

DG-DEN-3421-1 12 Aug 2020

No space after inputs, outputs, just ":" then space to be consistent everywhere.

TESTSUITES-DEN-3724-1 15 Oct 2020

RESOLVED

DG-DEN-3421-1 12 Aug 2020

Replace For now with TODO

DG-DEN-3421-1 19 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 19 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 19 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 19 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 12 Aug 2020

Define few seconds, too vague.

DG-DEN-3421-1 19 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 19 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-5283-1 19 Oct 2020

removed.
applied the described rules.

DIALIN-DEN-5283-1 19 Oct 2020

RESOLVED

DIALIN-DEN-5283-1 19 Oct 2020

RESOLVED

UI-DEN-5283-1 19 Oct 2020

This is not UI Application Software naming conventions.
This enum comes from HDDefs.h@223 as part of the Firmware shared code with Software on Common repo.
In short, it is not our code.

DIALIN-DEN-3421-1 07 Dec 2020

The new parameter is missing from the docstring

DG-DEN-8030-1 13 Jun 2021

Done.

DG-DEN-6080-1 29 Dec 2020

Done

HD-DEN-5053-1 15 Oct 2020

Suggest removing extra colon between param name and description.

DG-DEN-3421-1 12 Aug 2020

No space after inputs, outputs, just ":" then space to be consistent everywhere.

DG-DEN-6080-1 28 Dec 2020

Use parentheses to separate conditions.

DG-DEN-3421-1 19 Oct 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-5751-1 01 Feb 2021

RESOLVED.

DG-DEN-3421-1 19 Oct 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4964-1 14 Oct 2020

"1. Any violation to the guide is allowed if it enhances readability. The justification must be provided in the source code, where the violation occurs. In addition, approval for the violation must be granted by Software Engineering Management, Software Engineering, and Quality."

Changing parameter names to enhance readability is encouraged by our coding standard, so much that any violation to enhance readability (with justification) is allowed.

vData and "data" is not descriptive or meaningful, so its usage violates "4. Functions and variables should have descriptive and meaningful names..."