In that case, the given mode is illegal and no action is taken and result is returned FALSE. Dialin will see the FALSE return and know it was unsuccessful.
waitForObjectExists wasn't using the timeout of 200 ms set in config.xml. I've updated the test use waitForObject which waits until the component is visible before clicking, so the delays are not needed and are now removed
This review has so many files and is quite monumental. It would be much easier to review if there were fewer changes. What are the list of features that are covered in this review? It seems like it's not just doxygenization
Why a simple name, address value set has been converted to a Jason Document by that complicated dereferencing and casting of pointers and passed over all the stacks of signal/slots instead of a simple struct?
We need to move this check out of else condition and use the if condition. The persistent alarm check function need to be switching between true and false cases to work, otherwise we need to use windowed time count.
After the Doxygeization effort, all the classes shall have the documentation with messaging information. Please add to all your classes. For example on how to do please refer to the Model/View classes. And when doc generated it will also be used for SDD. it should contain:
\brief
\details
Message information
Message Payload information as each field in a line (see example below)
\sa(see also) which has related classes to this class
Logging info which at least has 3 lines (see example below and follow the HTML syntax for formating in doxygen please.)
An example provided. please look at more examples for your specific case in the code on the master branch.
