This file was subsequently renamed to MTreatmentParameters.h and then was removed when I subclasses MModel in MTreatmentAdjustRequests.h to create the MAdjustTreatmentParametersReq class. Do you want me to rename MAdjustTreatmentParametersReq to MTreatmentParametersRequest?
I'm not sure I see what's the issue to resolve here since I notice only a helper method for waitForObjectExists of SquishQt. And also I would strongly not want to play with SquishQt APIs so when an error happens or when the test is not working I don't want to debug the helper or wrappers and want to only focus on the test. Please use simple direct SquishQt API. You are free to do any sophisticated logic in dialin but please keep the tests as simple as possible (just copy/paste if applicable) and only use SquishQt API unless it's absolutely necessary.
Let's all agree to do it this way moving forward. I like the arrangement of files in their corresponding buckets, denali.pro looks much cleaner this way.
Definitions: _data is used for private data member vData is used for method argument Data is used for data type
Moving forward, my expectation is for all of us to follow the same naming convention. I have also requested BehrouzN to update the C++ Coding Standards.
There should be a description in words describing what this function does. There should be a type for each parameter and a description of the parameter. Right now the documentation is missing: X:/Users/Bamboo-Projects/DEN_DX/Dialin/Doxument-master/html/dialin.squish.html Have you tested the frame diagram with sphinx?
In this function, this is not the correct test data provided. it is not covering all the different data. for each byte, there should be a line and if those bytes are related to a parameter should be numbered the same and each param has a different number. So for 18 params and every 4 bytes, it should be 18x4 line of data with and extra for the message completer also do not break the lines it is a test data, not a code. And why all the parameters are 00 there should be different values used to see if the function can handle anything other than one value like 00.
