•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-4598-1 04 Nov 2020

Done

UI-DEN-4598-1 04 Nov 2020

Done

HD-DEN-5674-2 04 Jan 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4598-1 04 Nov 2020

It was actually unused, so I've just deleted it for now (See http://dvm-linux02:8060/cru/#UI-DEN-4598-1CFR-19459)

UI-DEN-4598-1 03 Nov 2020

Please align.

UI-DEN-4598-1 03 Nov 2020

Please use the value 0x3500 instead of 53 decimal.
I'm also updating all to be the hex values.
Although the "message list" has decimal values this is the exact value we can trace in the "candump" output and helps a lot while debugging.

DG-DEN-5846-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5846-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 04 Jan 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4641-1 01 Dec 2020

Fixed.

HD-DEN-4641-1 01 Dec 2020

Fixed.

UI-DEN-5736-1 01 Dec 2020

DEN-5928: Investigation on the ultrafiltration founded bug

Created a Bug for investigation put on next spring.
Created a tag on this git commit.
Put enough information in the bug description.

DIALIN-DEN-5674-2 30 Dec 2020

Shouldn't the treatment parameters be published here like they are in _handler_treatment_param_settings?

DG-DEN-5873-1 01 Dec 2020

Done

DG-DEN-5873-1 01 Dec 2020

Done

HD-DEN-4641-1 01 Dec 2020

How are we tracking TODO items? Do we search for both TODO before release or for both TODO and TBD? I believe we should stick to TBD only.

HD-DEN-4641-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4641-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4641-1 01 Dec 2020

Please comment the variables in the structure.

DG-DEN-5980-1 22 Feb 2021

Rather than changing this, maybe you could just not define SKIP_POST? The SKIP_POST build flag should skip all POST.

UI-DEN-5736-1 03 Dec 2020

RESOLVED.

DG-DEN-5855-1 03 Dec 2020

It has been renamed and also has been moved to the RO pump branch.

DG-DEN-5980-1 22 Feb 2021

We have a lot of available message IDs above. Why are we using them first before creating new msg IDs?

UI-DEN-5736-1 03 Dec 2020

RESOLVED

DG-DEN-5873-1 07 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-6372-1 27 Feb 2021

Align comment.

DG-DEN-5846-1 07 Dec 2020

Same comment as above.

DG-DEN-3504-1 07 Oct 2020

Another condition to add here: If we auto-cal one or both load cells, we should consider the drain activity completed (we cannot drain any further) and exit drain mode.

UI-DEN-4964-1 14 Oct 2020

Based on my review of the QObject classes underneath, the whole intent of the VIEW_DEF and VIEW_DEC macros is to provide a much more simplistic interfaces to the user when wanting to create views and their corresponding data. We also made the decision to not touch these two macros. Hence, my expectation is for all features implemented moving forward to follow this design pattern.

Note: If someone wants to look at the definition of these macros, they can always go back to their corresponding *.h.

DG-DEN-3504-1 02 Nov 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-5751-1 01 Feb 2021

UI_DVT related.

DG-DEN-8030-1 13 Jun 2021

I removed it.

UI-DEN-4598-1 04 Nov 2020

RESOLVED.

HD-DEN-5674-2 30 Dec 2020

What does this comment mean? Are we adding colors (green + red is brown, not yellow)? Are we adding bits or states (then be explicit)?

HD-DEN-5674-2 30 Dec 2020

we have (formal) instead of we've (informal)

UI-DEN-4598-1 03 Nov 2020

Please move this test into the tst_models.
Generally, we should never have any more tests in the tst_canbus, tst_threads, tst_messaging, tst_logging and so.
Those are specific to the very fundamental functionalities of the UI Software.
Also then remove the

friend tst_canbus

from the classes which has been tested here.

DIALIN-DEN-4691-1 09 Nov 2020

milliliter in one word

DG-DEN-5846-1 01 Dec 2020

Replace with TODO

UI-DEN-4598-1 02 Nov 2020

Done
It is removed now

UI-DEN-5751-1 01 Feb 2021

UI_DVT related.

HD-DEN-5381-1 17 Dec 2020

Added common into code review.

DIALIN-DEN-11980-1 16 Feb 2022

RESOLVED.

UI-DEN-5751-1 01 Feb 2021

RESOLVED.

HD-DEN-4641-1 01 Dec 2020

Added @param.

DG-DEN-5873-1 01 Dec 2020

Changed the flag to an enum.

HD-DEN-4641-1 01 Dec 2020

Recommend changing all the PWMs to duty cycle for consistency.

DG-DEN-6080-1 29 Dec 2020

Need comments for Doxygen.

DG-DEN-5873-1 02 Dec 2020

Done

HD-DEN-5381-1 17 Dec 2020

I didn't see these states defined in this module. Where is the enum declared? If in common, I don't see common code in this code review project.

DG-DEN-5864-1 02 Dec 2020

Yes that is right. It should be an F32. I fixed it.