•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-5846-1 04 Dec 2020

Removed part that was checking for 0 RPM.

DG-DEN-5846-1 07 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5846-1 07 Dec 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-5777-1 01 Feb 2021

16GB and 2.4GB (units are Bytes).

UI-DEN-5830-2 12 Jan 2021

RESOLVED

UI-DEN-6349-1 12 Jan 2021

Done

UI-DEN-6349-1 13 Jan 2021

It has been updated to TextEntry

UI-DEN-6349-1 08 Jan 2021

please use "Item" instead of "Rectangle" with color as transparent when possible.

UI-DEN-6349-1 08 Jan 2021

same here for arguments name

UI-DEN-4860-BLE-1 12 Jan 2021

same

DIALIN-DEN-3421-1 07 Dec 2020

These should be in msg_defs.py instead of here

DIALIN-DEN-3421-1 07 Dec 2020

Need type information to sensor_value, sensor_index, and reset in the docstring

DG-DEN-3504-1 02 Nov 2020

Done.

UI-DEN-3605-4 14 Oct 2020

Okay so in that case I need to guess about what you're asking for. My guess is you want it to be named to AdjustTreatmentParametersRequestData.
This is how it's currently named.
Please indicate if you prefer otherwise or mark resolved.

DG-DEN-3504-1 02 Nov 2020

Need a space after each break.

UI-DEN-4964-1 14 Oct 2020

RESOLVED

DG-DEN-3504-1 02 Nov 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4964-1 16 Dec 2020

Please do the same for the Versions.

UI-DEN-5751-1 01 Feb 2021

UI_DVT related.

HD-DEN-7395-1 12 Apr 2021

Addressed.

UI-DEN-5751-1 01 Feb 2021

UI_DVT related.

DG-DEN-8030-1 13 Jun 2021

I removed the function.

DG-DEN-5855-1 03 Dec 2020

Done

UI-DEN-4598-1 02 Nov 2020

Yes, this is to be able to run the squishqt tests in a headless mode.
Sounds good, I will work with Dara to get this on the server as well.

UI-DEN-5751-1 01 Feb 2021

RESOLVED.

UI-DEN-4598-1 03 Nov 2020

Done

UI-DEN-4598-1 03 Nov 2020

RESOLVED

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4598-1 09 Nov 2020

RESOLVED

UI-DEN-4598-1 01 Nov 2020

if this variable keeps the name of the file which has the manufacturing default settings, I think the naming should be more descriptive.

DG-DEN-8030-1 13 Jun 2021

Done.

DIALIN-DEN-3504-1 09 Nov 2020

Removed.

DIALIN-DEN-3504-1 04 Nov 2020

Why removed?

DIALIN-DEVELOP-BUG-FIXES-1 04 Nov 2020

Spell out Fld to understand variable name.

HD-DEN-5674-2 30 Dec 2020

we have (formal) instead of we've (informal)

DG-DEN-5846-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

we will (formal) instead of we'll (informal)

DG-DEN-5846-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5846-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5846-1 04 Dec 2020

Removed this function from here and moved it to execFans.

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

we are (formal) instead of we're (informal)

HD-DEN-4641-1 01 Dec 2020

Done.

HD-DEN-7117-1 06 Apr 2021

Done.

HD-DEN-4641-1 01 Dec 2020

These are enums that are available (I something there but later they became obsolete). So I'm trying to call attention to these so they will be used again.

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4641-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4641-1 01 Dec 2020

Why so many underscores? (there are 6 lines in this file having this issue)

HD-DEN-4641-1 01 Dec 2020

Need to update parameters.

HD-DEN-5674-2 30 Dec 2020

Done.