Comment Search

It's not about what I want, it's about code consistency.
The comment I put up there was regarding a conversation we had about Data at the end and how Data is going to be in the naming and that time I didn't care about the specific Model and Treatment was an example.
I don't think I don't even need to tell you want it should look like as you put your code there it needs to be like the other ones next to it.
So please just be consistent.

RESOLVED in CODE WALKTHROUGH.

I don't know if it is mandatory, but we adopted a new way to transfer publish data to broadcast function using a public struct in the .h file and passing a pointer from it. I think we should do it that way everywhere.

Done.

Done.

Done.

Please define these magic numbers somewhere and use them here then.
As example :

//// PRS/SRS defined values
const quint32 bloodFlowRate_def = 100; // SRS nnnn : manufacturing default
const quint32 bloodFlowRate_min = 100; // SRS nnnn
const quint32 bloodFlowRate_max = 100; // SRS nnnn
const quint32 bloodFlowRate_res = 100; // SRS nnnn : resolution
....

RESOLVED in CODE WALKTHROUGH.

A lot of these #includes are already in SystemCommMessages.h and so should probably be removed from this area as they are redundant.

Should be an else (or default if you turn this into a switch) that triggers a s/w fault (bad reservoir param).

RESOLVED in CODE WALKTHROUGH.

Do we need to consider the case where ctrlMode is >= NUM_OF_PUMP_CONTROL_MODES?

RESOLVED in CODE WALKTHROUGH.

Add new alarms to the below alarm table.

Added the if statements to make it symmetrical.

There should not be any data received at this time

RESOLVED in CODE WALKTHROUGH.

Done.

RESOLVED

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Please add the message definition this method implements on top of the class like what you did for MDGAccelerometerData.h

please document the class with the format like the example below:
\sa (see also) should refer to the mode data which is used in this class in your case Model::DGAccelerometerData

/*!
 * \brief   The VDGDrainPump class
 * \details View for Model's Data  representation.
 *
 * \sa Model::MDGDrainPump
 *
 */

Please refer to more examples in the master branch and do the same for other Model/View classes.

As a tip just above your class name type "/*!" and hit enter to let QtCreator complete the scaffold for you.