•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4964-1 13 Oct 2020

This should go under Views - HD - Data

UI-DEN-3605-4 07 Oct 2020

I think you forgot what you told me previously and you're going to tell me to change it again if I don't remind you of why you told me to rename it to MAdjustTreatmentParametersRequest in the first place.

Previously, you complained that there was no Adjust prefix and no RequestData suffix, so I've since updated it to match that.

For example:

    REGISTER_METATYPE(                                AdjustUltrafiltrationConfirmRequestData ) \
    REGISTER_METATYPE(                                                AdjustSalineRequestData ) \
    REGISTER_METATYPE(                                   AdjustTreatmentParametersRequestData ) \


So you want me to rename it to this now?

    REGISTER_METATYPE(                                AdjustUltrafiltrationConfirmRequestData ) \
    REGISTER_METATYPE(                                                AdjustSalineRequestData ) \
    REGISTER_METATYPE(                                                TreatmentParametersData ) \


Please choose. I've already updated it to match the first so it's like the other code.

DIALIN-DEN-7135-1 11 Apr 2021

If you don't mind let's address it in the "DEN-7820:UI_DEV: Post-Treatment" story.

UI-DEN-4690-1 07 Oct 2020

Added

HD-DEN-4640-1 12 Oct 2020

Suggest expanding these macros.

DG-DEN-3504-1 02 Nov 2020

Done.

DG-DEN-3504-1 02 Nov 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3504-1 02 Nov 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3504-1 02 Nov 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4598-1 03 Nov 2020

It has been removed: http://dvm-linux02:8060/cru/#UI-DEN-4598-1CFR-19817

UI-DEN-4598-1 04 Nov 2020

RESOLVED.

UI-DEN-4598-1 04 Nov 2020

RESOLVED.

UI-DEN-4598-1 09 Nov 2020

Please remove sleeps as much as possible.
Only keep if it's related to the UI navigation animation.
in that case also please use utils.waitForGUI(<sec>).

DG-DEN-5846-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4598-1 04 Nov 2020

denali.conf is currently used and if it exists, the treatment parameters are read directly into a QJsonObject on startup
denali.csv is currently unused and so I've just deleted it for now (See http://dvm-linux02:8060/cru/#UI-DEN-4598-1CFR-19459)

DG-DEN-5846-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-4640-1 09 Nov 2020

HD is still part of the msg name. Peter had me move all of these msg ID definitions to a common enum (moved from "self" to common MsgIDs enum).

UI-DEN-4598-1 01 Nov 2020

Please document why this file is created.
And Please move it to its appropriate folder "./sources/gui/qml/components".

UI-DEN-4598-1 01 Nov 2020

Could you please explain why added delays?
It was/is working without delay.
The preferred way is not to slow down the test to have a successful test.
I recall we had this conversation.
Please remove the sleep functions.

UI-DEN-4598-1 01 Nov 2020

what is the difference between these two?
namings show the variable "Treatment_Parameter_Ranges_Path" should be
"/media/sd-card/treatment/" and not
"/media/sd-card/treatment/denali.conf"
and "denali.conf" needs to be removed, right?

DG-DEN-6080-1 29 Dec 2020

Done

DG-DEN-6080-1 29 Dec 2020

I don't see alarm ID split in this review (AlarmDefs.h). Add common repositories to this review.

HD-DEN-5381-1 17 Dec 2020

Should reset state to start state here or we won't be able to do a second treatment.

HD-DEN-5674-2 29 Dec 2020

Will update all comments to start w/ capital letter.

HD-DEN-5887-1 30 Dec 2020

Done.

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-6080-1 29 Dec 2020

Any time we're pulling the safety line, there should be a fault triggered as well - otherwise s/w will be expecting things to continue operating normally and, of course, with safety line pulled they won't - causing a potential slew of alarms that won't make sense.

DG-DEN-6081-1 29 Dec 2020

Always trigger a fault when pulling the safety line.

DG-DEN-6081-1 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-6081-1 28 Dec 2020

Suggest replace target RO pump pressure function call with local variable targetFlowRate and separating condition using parentheses

HD-DEN-5887-1 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

we are (formal) instead of we're (informal)

HD-DEN-5674-2 30 Dec 2020

we are (formal) instead of we're (informal)

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 30 Dec 2020

Fixed.

UI-DEN-4964-1 03 Jan 2021

please remove the if statement (L249) as well which checks the length of the vData, as well.

UI-DEN-4964-1 03 Jan 2021

RESOLVED

HD-DEN-5674-2 04 Jan 2021

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5674-2 04 Jan 2021

RESOLVED in CODE WALKTHROUGH.

UI-DEN-4860-BLE-1 18 Jan 2021

RESOLVED

UI-DEN-6349-1 19 Jan 2021

RESOLVED.