Indent everything to align.
RESOLVED in CODE WALKTHROUGH.
RESOLVED
Added more comment to explain that.
Added another elseif to increment it.
Done.
Please define these magic numbers somewhere and use them here then.
RESOLVED.
Done
Done, see the other Variables.qml to the left. http://dvm-linux02:8060/cru/#UI-DEN-3605-4CFR-16980
Should the air trap valve be set to closed in init?
This function name is not clear. What does it do?
check valve param is valid.
Comments should say "self" not "set"?
Remove extra line.
remove this, please. It's not standard.
So do you know how to tell QtTest not to run it automatically? Please move it to a private section of the class if it is just a helper function. Please refer to the comment for the implementation. I strongly disagree with this way of testing.
Found in another Variables.qml. RESOLVED.
Done, will post update soon
I've removed it and will post an update to this review soon.
Need to add the types for each parameter as well to be consistent with the other dialin classes
Done - See http://dvm-linux02:8060/cru/UI-DEN-3605-4#CFR-16985
Done - See commits from a19862d to 810e4b1 (drag the slider at the top)
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
