•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-4690-1 09 Sep 2020

RESOLVED.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5381-1 17 Dec 2020

Done.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

UI-DEN-3605-4 09 Sep 2020

I've updated the class name now to MTreatmentParameters.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4211-1 28 Aug 2020

Why is rotation direction is set in this function? Is there a need to define positive and negative flows as part of flow rate override?

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 22 Sep 2020

The status is used to check the bit status according to the mode that we are in. For instance, if we are in bypass mode, PID enabled must be 0 and bypass enable must be 1. PID initialized will be always 1.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 22 Sep 2020

Done

DIALIN-DEN-3875-1 28 Aug 2020

RESOLVED.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-3875-1 28 Aug 2020

RESOLVED.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5053-1 22 Sep 2020

Function name and doxygen comment not match.

HD-DEN-4211-1 28 Aug 2020

Rename function name to match.

HD-DEN-4308-3 23 Sep 2020

Added a function to get the status of air trap valve.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 23 Sep 2020

Done

DIALIN-DEN-4438-1 28 Aug 2020

OK.

HD-DEN-5053-1 22 Sep 2020

Expand macros.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5053-1 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-4438-1 28 Aug 2020

OK.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-4438-1 28 Aug 2020

OK.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4211-1 28 Aug 2020

RESOLVED in CODE WALKTHROUGH.