•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-3605-4 07 Oct 2020

I've updated it so the signal will only be called when the mouse press changes

http://dvm-linux02:8060/cru/UI-DEN-3605-4#CFR-16966

UI-DEN-4690-1 30 Sep 2020

RESOLVED.

DIALIN-DEN-4308-1 30 Sep 2020

Done

UI-DEN-3605-4 06 Oct 2020

This has since been updated on the latest development branch as follows:

 
        case Gui::GuiActionType::ID_EndTreatmentReq: {
            if ( count != 0 ) { logInvalidLength(vActionId); return false; }
            vPayload = Format::fromVariant(vData);
            LOG_EVENT(EndTreatmentRequestData::toString(vData));
        } break;

        case Gui::GuiActionType::ID_CreateTreatmentReq: {
            if ( ! count ) { logInvalidLength(vActionId); return false; }
            vPayload = Format::fromVariant(vData);
            LOG_EVENT(AdjustTreatmentParametersRequestData::toString(vData));
        } break;


http://dvm-linux02:7990/projects/UI/repos/application/browse/sources/canbus/messageinterpreter.cpp?at=refs%2Fheads%2FDEN-4598-Confirm-Priming-Begin

DIALIN-DEN-4308-1 30 Sep 2020

Done

DIALIN-DEN-4690-1 06 Oct 2020

fixed.

DIALIN-DEN-4308-1 30 Sep 2020

Done

UI-DEN-4598-1 01 Nov 2020

As a general note Please try not to create a component for every single use case.
I'm also started to remove some of the currently defined unnecessary components to keep them more organized.

UI-DEN-4690-1 06 Oct 2020

This file doesn't exist anymore.
For some reason, Crucible is showing it.

UI-DEN-3605-4 06 Oct 2020

RESOLVED

UI-DEN-4598-1 09 Nov 2020

RESOLVED

UI-DEN-4690-2-1 30 Sep 2020

This file has been renamed to singletone.h._ and has been removed by Peman request.
So this file doesn't exist anymore.

UI-DEN-3605-4 06 Oct 2020

Please put a short description of your component and explain what it does and where it can be used.
Since it is a specific or compound component and is not a general component like a just a Slider or Progressbar, it helps to understand the use case of the component.

DIALIN-DEN-4308-1 30 Sep 2020

RESOLVED.

DIALIN-DEN-4308-1 28 Sep 2020

Remove extra line.

UI-DEN-4598-1 30 Oct 2020

I checked out into the branch and

 using namespace Storage; 

is still there.
I couldn't find any use case if that's so please remove.

DG-DEN-5846-1 30 Nov 2020

Add "_STATE" to end of each enum name and "state" to end of each comment.

DIALIN-DEN-4308-1 30 Sep 2020

This handler will be removed.

UI-DEN-3605-4 30 Sep 2020

A test should be self-contained.
QTest supposes to call this test function automatically. so what happens to the parameter view?
If this test needs an object it has to be created in the test function.

UI-DEN-4690-1 30 Sep 2020

Okay could you put a comment in indicating that it's for the different displays so its clear?

UI-DEN-4690-1 09 Sep 2020

These comments should be deleted, no? If they are serving a purpose, there should be some description as to why there are kept

UI-DEN-3605-4 30 Sep 2020

What is it and where has it been used ?

UI-DEN-3605-4 28 Aug 2020

Remove 3 extra lines.

DIALIN-DEN-3875-1 28 Aug 2020

Hey Peter,
You're right I removed them to easier do the merge.
Since the task DEN-4690: Doxygenization has been changed to story and there is a code review sub-task for that, let's address all the documentation in that stoy.

UI-DEN-3605-4 28 Aug 2020

Remove extra line.

UI-DEN-3605-4 28 Aug 2020

Done

UI-DEN-3605-4 28 Aug 2020

Remove 2 extra lines.

UI-DEN-3605-4 28 Aug 2020

Done (see the other messageglobals.h file for the change)

UI-DEN-4690-1 09 Sep 2020

RESOLVED.

UI-DEN-3605-4 28 Aug 2020

RESOLVED.

UI-DEN-3605-4 30 Sep 2020

why added 'c' at the beginning of the name?
None of the other constants in the Variable doesn't have it.

DIALIN-DEN-4690-1 09 Sep 2020

These are all the FW specific values and terms I don't know about them much and not all of them are used.
So I don't know the specific definition for them to put them.
We need to ask the FW team to provide us more descriptive definitions than the one in the Messaging List.
Or dig deep into the FW SDD to find them out.

UI-DEN-3605-4 09 Sep 2020

I looked into subclassing MAbstract at the time and again today but there's some incompatibility there that needs to be worked through.
How about I work on subclassing MAbstract in my current story? I don't think it would be good to change too much structure against these revisions as the code has been sitting for awhile and other things have changed quite a bit. Also, I think the MAbstract class may have been added near the end of my development on DEN-3605.
I'd like to make sure our models and code structure are all aligned too. I think it's better to do that on the latest code rather than the branch this code is sitting on which is outdated at this point.

DIALIN-DEN-9906-1 11 Nov 2021

RESOLVED.

UI-DEN-3605-4 28 Aug 2020

RESOLVED.

UI-DEN-4690-1 09 Sep 2020

RESOLVED.

UI-DEN-3605-4 28 Aug 2020

Done

UI-DEN-3605-4 05 Oct 2020

After the review the implementation is fine.
RESOLVED.

HD-DEN-9480-1 10 Nov 2021

remove postPassed

UI-DEN-4690-1 09 Sep 2020

RESOLVED.

UI-DEN-3605-4 28 Aug 2020

Here is a link to the crucible bug: https://jira.atlassian.com/browse/CRUC-6806. Looking over it, it seems they are not planning on fixing it

HD-DEN-4308-3 05 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-3875-1 28 Aug 2020

Removed in the latest code review which is the Saline Bolus.
You'll also have it in Doxygenization.

UI-DEN-4964-1 16 Dec 2020

Please add the message definition this method implements on top of the class like what you did for MDGAccelerometerData.h

DIALIN-DEN-4690-1 09 Sep 2020

RESOLVED.

HD-DEN-4211-1 28 Aug 2020

All of this is EMC test code per #ifdef above (~line 75) so this code is going away soon.

HD-DEN-4211-1 28 Aug 2020

One liner

UI-DEN-3605-4 05 Oct 2020

RESOLVED

DIALIN-DEN-4169-1 09 Sep 2020

One liner

DIALIN-DEN-4169-1 09 Sep 2020

RESOLVED.