So this would indicate we're in an invalid state for treatment parameters mode which shouldn't be possible unless memory was corrupted (stack overflow or buffer overflow, ...). So we will trigger a s/w fault (generic something bad happened in s/w fault) with supporting data of 1) a unique # (enum) to indicate this s/w fault is an invalid treatment parameters mode state and 2) what was the invalid state ID that s/w saw. All of that will be logged by UI. This is all part of the TODO which I have addressed in next commit.
Do not agree with this delay. Your implementation should not depend on a wait and if you that important to make sure it is done you need to have signal in your class to emit when write or read is done. Also you are using the static method and that function is pauseing the current thread I believe using the static method will pause the entire test. This is not a good test. Please also look at the link below: https://doc.qt.io/qt-5/qthread.html#msleep
It's necessary for adding delays since the file writer class runs in a separate thread. To check that a file was written, we wait for more than enough time before checking the file was written properly.
I believe it was better to do it like the other classes and use SquishQt to test the whole stack of MVC and if that didn't work cover more in here with simple small functions. The test functions are so big and have so many compare in just one function. This is not the correct way of testing.
This was an old idea I'd had about something we might want Dialin to be able to do, but seeing how Dialin has evolved it's clear we will not be doing this.
Hey Peter, You're right I removed them to easier do the merge. Since the task DEN-4690: Doxygenization has been changed to story and there is a code review sub-task for that, let's address all the documentation in that stoy.
