I didn't realize you were already working on the UI sound playback. Are you planning on leaving this class as or will continue to work on playing sound?
This file has been replaced with its Camel Case version. But since it had a copyright change on server which had no code review assigned to it Crucible is showing it here after I merged master into my branch. So actually this file doesn't exist anymore.
I put comments on every function. Is there a function that doesn't have a comment? As I mentioned there are some parameters that UI doesn't use and doesn't know the description.
"*** Off the subject ***" This is not related to the story and is a code coverage of another story. Regardless it was decided to manually test the CANBus at that moment since it could be better tested with more accurate results which all of those test couldn't be achieved manually and took a long time to test because 10 or 100 of thousands of frames tested and wasn't reasonable to do it each time automatically on server with virtual CANBus and had to be tested on a real physical CANBus. I hope this is enough information!
If you look at the latest revision of main.h on the Confirm-Priming-Begin branch you'll see I've since added a min / max, a default, as well as a resolution value as a parameter to the TREATMENT_PARAMETER macro. PROPERTY only has three parameters. TREATMENT_PARAMETER needs these extra parameters, and is implemented differently to serve the different needs of treatment parameters. I left PROPERTY alone since other code depends on it.
This review has so many files and is quite monumental. It would be much easier to review if there were fewer changes. What are the list of features that are covered in this review? It seems like it's not just doxygenization
