Comment Search

Done - See the bottom of main.qml here http://dvm-linux02:8060/cru/UI-DEN-3605-4#CFR-16981

Good point, but I don't know.
Seems like it's the way Crucible prefers to show the files.
It has been removed and even the git log shows that.
This commit is the last commit no the ApplicationController and there is no applicationcontroler on that commit anymore.
http://192.168.10.132:8060/changelog/application/?cs=bb74da05f81b82dad3ec844c1feb1135b949f1c2

This file has been replaced with its Camel Case version.
But since it had a copyright change on server which had no code review assigned to it Crucible is showing it here after I merged master into my branch.
So actually this file doesn't exist anymore.

Done - see http://dvm-linux02:8060/cru/UI-DEN-3605-4#CFR-16971

Done

Done

Done

Remove all commented lines, or add TODOs.

When I tested initially with

_column.height 

, the flickable content height was wrong. Using

_column.implicitHeight

fixed this issue

I kept these files noncapital since they have short one word only files and no need to be PascalCase.

RESOLVED.

RESOLVED.

put.

Done

Please follow the code structure for consistency.
Why this class doesn't start with M like all the other Model classes?

RESOLVED

RESOLVED.

Done

If you look at the latest revision of main.h on the Confirm-Priming-Begin branch you'll see I've since added a min / max, a default, as well as a resolution value as a parameter to the TREATMENT_PARAMETER macro.
PROPERTY only has three parameters. TREATMENT_PARAMETER needs these extra parameters, and is implemented differently to serve the different needs of treatment parameters.
I left PROPERTY alone since other code depends on it.

RESOLVED.

The file should be renamed to match this.

RESOLVED

RESOLVED

RESOLVED

Why didn't use the attached scrollbar instead of non-attached?
regarding the Qt doc :
When using a non-attached ScrollBar, the following must be done manually:
When using a non-attached ScrollBar, the following must be done manually:
Layout the scroll bar (with the x and y or anchor properties, for example).
Set the size and position properties to determine the size and position of the scroll bar in relation to the scrolled item.
Set the active property to determine when the scroll bar will be visible.

your code could be as simple as :

Flickable {
...
 ScrollBar.vertical: ScrollBar { id: scrollBar }
...
}