•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-3605-4 28 Aug 2020

Done

DIALIN-DEN-5053-1 29 Sep 2020

RESOLVED.

UI-DEN-3605-4 28 Aug 2020

Done

UI-DEN-3605-4 28 Aug 2020

Done

DG-DEN-3504-1 30 Oct 2020

I think minimum and maximum already indicates the smallest and highest value. Removed allow.

DIALIN-DEN-3421-1 11 Dec 2020

RESOLVED

UI-DEN-3605-4 08 Sep 2020

Please follow the code structure for consistency.

None of the methods in this category has Data at the end, why this one has?
and the ones who are not using the notify template method yet, have the adjust at the begging of the name, why this one hasn't?

UI-DEN-4690-2-1 30 Sep 2020

How come these files have been renamed but they have not been deleted to show in red?

UI-DEN-3605-4 28 Aug 2020

RESOLVED.

UI-DEN-4690-1 09 Sep 2020

These are different color themes on the UI screens which I found during testing on different displays.
I would rather keep them until a good release.

UI-DEN-3605-4 28 Aug 2020

RESOLVED.

UI-DEN-4690-2-1 30 Sep 2020

How come renaming of files was done but the old files are not shown in red as deleted/

UI-DEN-3605-4 28 Aug 2020

RESOLVED.

UI-DEN-4690-2-1 30 Sep 2020

How come the renaming was done on all these files but the older files are still there and not marked as removed in red?

UI-DEN-3605-4 28 Aug 2020
HD-DEN-7117-1 06 Apr 2021

Good catch. Fixed.

DIALIN-DEN-3875-1 28 Aug 2020

RESOLVED

HD-DEN-4641-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4211-1 28 Aug 2020

I guess this is a double negative so it's confusing, but I try to keep the normal state first in these #if build switches.
So this one is a #ifndef which is the normal path where accelerometer feature is enabled. And so the #else is the abnormal state where accelerometer is disabled.

HD-DEN-4211-1 28 Aug 2020

disable accels? Or, enabled accels?

HD-DEN-4211-1 28 Aug 2020

Why removed?

HD-DEN-4211-1 28 Aug 2020

Why removed?

UI-DEN-4964-1 14 Oct 2020

Will do.

Let's all agree to do it this way moving forward. I like the arrangement of files in their corresponding buckets, denali.pro looks much cleaner this way.

UI-DEN-4690-1 09 Sep 2020

RESOLVED.

DG-DEN-5846-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-4690-1 14 Oct 2020

RESOLVED

HD-DEN-4211-1 28 Aug 2020

I amended comment to clarify these are all for development builds only - Bamboo will never see any of these.
As for which dev build switches are commented out or not, this is just how they are used. You un-comment a switch to get that special test feature/behavior as needed. You comment it out to turn it off.
So this isn't TODO situation. It's just a means to facilitate all of the various test build requests I get.

UI-DEN-3605-4 15 Sep 2020

Done

UI-DEN-3605-4 30 Sep 2020

Why added QThread?

HD-DEN-4308-3 21 Sep 2020

Suggest adding an else to capture other valve modes.

UI-DEN-3605-4 08 Sep 2020

Please follow the code structure for consistency.
The naming like all the other Model classes should be :
typedef Model::<Class>::Data <Class>Data;
The chosen name is not consistent and also is too short and doesn't show the content type.
In this case, it should also have Adjust at the beginning as well, if I understood the class purpose correctly.

DG-DEN-5846-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5846-1 01 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-4308-1 30 Sep 2020

Done

UI-DEN-4690-1 30 Sep 2020

RESOLVED.

DIALIN-DEN-4308-1 30 Sep 2020

Done

HD-DEN-4308-3 30 Sep 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 30 Sep 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 30 Sep 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-4308-1 30 Sep 2020

Where is common?

DIALIN-DEN-4308-1 30 Sep 2020

Done

UI-DEN-3605-4 30 Sep 2020

Update, it's now MAdjustTreatmentParametersRequest and AdjustTreatmentParametersRequestData as per our last conversation

DIALIN-DEN-4308-1 30 Sep 2020

RESOLVED.

DIALIN-DEN-4308-1 30 Sep 2020

RESOLVED.

DIALIN-DEN-4308-1 30 Sep 2020

RESOLVED.

DIALIN-DEN-4308-1 30 Sep 2020

RESOLVED.

UI-DEN-4690-1 30 Sep 2020

Okay, RESOLVED.

UI-DEN-4690-1 30 Sep 2020

I didn't realize you were already working on the UI sound playback. Are you planning on leaving this class as or will continue to work on playing sound?

HD-DEN-5053-1 25 Sep 2020

Somehow the commands missed this. Need to add @details and remove extra space.

UI-DEN-4438-1 28 Aug 2020

RESOLVED.