•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-4308-3 21 Sep 2020

Expand the macro.

HD-DEN-4308-3 21 Sep 2020

Should there be an else to capture all other cases?

HD-DEN-4308-3 18 Sep 2020

Aligned doxygen comment.

HD-DEN-4308-3 15 Sep 2020

It is not a blood trap. Please use air trap or bubble trap.

HD-DEN-4308-3 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-5053-1 25 Sep 2020

Should it be dialin to dg channel?

DIALIN-DEN-4308-1 30 Sep 2020

Done

DIALIN-DEN-4308-1 30 Sep 2020

Done

UI-DEN-4964-1 14 Oct 2020

Does VIEW_DEF support bidirectional messaging, e.g. UI to HD as well as HD to UI?

HD-DEN-4308-3 30 Sep 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-4308-1 30 Sep 2020

Done

UI-DEN-4690-2-1 30 Sep 2020

There needs to be documentation for this class

DIALIN-2 30 Sep 2020

RESOLVED

UI-DEN-4690-2-1 14 Oct 2020

RESOLVED.

DIALIN-DEN-4308-1 30 Sep 2020

RESOLVED.

UI-DEN-3605-4 14 Oct 2020

RESOLVED

UI-DEN-3605-4 08 Sep 2020

Please follow the code structure for consistency.
All the Model classes are checking each of the values to be convertible by GetValue.
Why this check has been ignored here.
Please notice that this is bytes conversion over CANBus you can receive any junk data and if you don't check the conversion correctly the you are showing incorrect data.

DIALIN-DEN-4856-1 14 Oct 2020

Yes, if it's already there no reason to remove it. I've added it back

UI-DEN-3605-4 07 Oct 2020

Please add the testsuites repository in this code review.
It's always part of the Code Review.

HD-DEN-5053-1 15 Oct 2020

Done.

HD-DEN-5053-1 15 Oct 2020

Revert this change for doxygen comment.

DG-DEN-3421-1 19 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3421-1 19 Oct 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-5053-1 19 Oct 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-3504-1 07 Oct 2020

The calibration offset will be what left over after a full drain.

DIALIN-DEN-4438-1 25 Aug 2020

Can you remove unrelated changesets from this code review? I'm seeing many of my changes in this review

UI-DEN-3605-4 08 Sep 2020

Please remove this !

UI-DEN-4438-1 28 Aug 2020

RESOLVED.

DIALIN-DEN-4211-1 28 Aug 2020

Where did the copyright header go?

UI-DEN-4438-1 28 Aug 2020

RESOLVED.

DG-DEN-5846-1 01 Dec 2020

You mean change the sentence?

UI-DEN-4438-1 28 Aug 2020

RESOLVED.

UI-DEN-4438-1 25 Aug 2020

Remove extra lines.

UI-DEN-3605-4 07 Oct 2020

It is deleted now

UI-DEN-4438-1 28 Aug 2020

RESOLVED.

UI-DEN-4598-1 01 Nov 2020

Why it has been changed?

UI-DEN-4438-1 28 Aug 2020

RESOLVED.

UI-DEN-4438-1 28 Aug 2020

RESOLVED.

UI-DEN-4438-1 28 Aug 2020

RESOLVED.

UI-DEN-4438-1 28 Aug 2020

RESOLVED.

UI-DEN-4438-1 20 Aug 2020

Why is indentation of } off?

UI-DEN-4438-1 28 Aug 2020

RESOLVED.

UI-DEN-4438-1 20 Aug 2020

Why is indentation of } off?

UI-DEN-4438-1 28 Aug 2020

RESOLVED.

UI-DEN-4438-1 28 Aug 2020

RESOLVED.

UI-DEN-4438-1 20 Aug 2020

Remove extra line.

UI-DEN-4438-1 28 Aug 2020

RESOLVED.

UI-DEN-4438-1 28 Aug 2020

RESOLVED.

UI-DEN-4438-1 28 Aug 2020

RESOLVED.

UI-DEN-4438-1 25 Aug 2020

Remove extra line and fix indentation of }.