Ah Crucible fooled me. This file has been removed. I checked and ApplicationController.cpp/h doesn't have the QJsonObject and QJsonDocument imports on the ConfirmPrimingBegin branch. The Storage namespace is used for SD Card related functions in this file.
As per our conversation today, due to the design changes with MAbstract.h and MModel.h that were merged to master on Aug. 31st, the create treatment models will be updated to subclass these parent classes. This work is going to be tracked in this ticket: http://dvm-linux02:8080/browse/DEN-4981
This function will be removed once those changes are implemented since after being subclassed, it can use notify instead.
This file has been completely removed. But since it had a copyright change on server which had no code review assigned to it Crucible is showing it here after I merged master into my branch. So actually this file doesn't exist anymore.
1 - pip uses requirements.txt to install dependencies. See tools/setup_environment.sh for more detail. 2 - What you're asking about is the offline install capability. I have created a ticket in Jira http://dvm-linux02:8080/browse/DIAL-34 to track this new feature request. 3 - The offline install capability addresses this situation, in the (very) unlikely event that pypi hosting can't be relied upon. 4 - No. My understanding is that we do not need to validate these libraries because Dialin is NPSW. 5 - It's fine to have all of these libraries. For example, some of them are dependencies of python-can. Periodically this requirements.txt will be cleaned if a library is no longer being used. For this change-set, I added flake8 so we can run static code analysis. Flake8 is installed along with its dependencies.
Do you have all the commits added to this code review? I don't see this comment either!!! Also, all the enum names are without ID_ which your latest push on your branch shows, they have !!!
We will want to auto-cal A2/B2 redundant load cells as well. One or neither or both load cells may require auto-cal if they stop falling before reaching target weight.
