•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-5736-1 01 Dec 2020

"notices" instead of "notice"

UI-DEN-4690-1 09 Sep 2020

This file has been removed.
But since it had a copyright change on server which had no code review assigned to it Crucible is showing it here after I merged master into my branch.
So actually this file doesn't exist anymore.
Please look at Please look at http://192.168.10.132:8060/cru/UI-DEN-4690-2-1

DIALIN-DEN-4308-1 02 Oct 2020

RESOLVED.

UI-DEN-4690-1 08 Sep 2020

Remove.

UI-DEN-4690-1 08 Sep 2020

If these files are part of the repo/build, Doxygen should look for them. If these files are not part of repo/build, then they should be removed. To have a better understanding, what is the purpose of these ._ files?

UI-DEN-4690-1 08 Sep 2020

Remove.

UI-DEN-4690-1 08 Sep 2020

This file is removed with its Camel Case name version.

HD-DEN-4308-3 05 Oct 2020

I did this after a merge from master Sean Nash could you please respond?

UI-DEN-4690-1 08 Sep 2020

This file is removed with its Camel Case name version.

UI-DEN-4690-1 08 Sep 2020

This file is replaced with its Camel Case name version.

UI-DEN-3605-4 05 Oct 2020

RESOLVED

UI-DEN-3605-4 08 Sep 2020

Please inherit from MAbstract.

UI-DEN-3605-4 08 Sep 2020

Resolved.

DIALIN-DEN-4308-1 06 Oct 2020

RESOLVED.

DIALIN-2 09 Sep 2020

I have updated it so it says Dialin now.

UI-DEN-4690-2-1 06 Oct 2020

RESOLVED.

DIALIN-DEN-4690-1 06 Oct 2020

Added

UI-DEN-3605-4 07 Oct 2020

RESOLVED

UI-DEN-3605-4 07 Oct 2020

RESOLVED

UI-DEN-4690-1 09 Sep 2020

The code documentation is missing

UI-DEN-4690-1 09 Sep 2020

This file has been replaced with its Camel Case version.
But since it had a copyright change on server which had no code review assigned to it Crucible is showing it here after I merged master into my branch.
So actually this file doesn't exist anymore.

DIALIN-DEN-4690-1 05 Oct 2020

"*** Please don't check "Needs Resolution" for each comment you made ***"
Added

UI-DEN-4690-1 09 Sep 2020

RESOLVED.

UI-DEN-4690-1 08 Sep 2020

Why does file name end in ._?

DIALIN-DEN-4211-1 09 Sep 2020

Yes

UI-DEN-4690-1 16 Sep 2020

Please refer to the newer code review after the max revision has been changed which has all the latest commits.
http://192.168.10.132:8060/cru/UI-DEN-4690-2-1
Seems like it has appeared here as well.

UI-DEN-3605-4 09 Sep 2020

I renamed it to TreatmentParametersData in line with the paradigm you've described:

 typedef Model::<Class>::Data <Class>Data; 

It's not adjusting a parameter during a treatment, so I don't think the Adjust naming would apply in this particular case.

HD-DEN-4308-3 22 Sep 2020

Should there be an alarm for invalid valve?

UI-DEN-4690-1 08 Sep 2020

Remove extra line.

DIALIN-DEN-4690-1 08 Sep 2020

Remove second copyright.

DIALIN-DEN-4690-1 08 Sep 2020

Remove second copyright.

DIALIN-DEN-4211-1 28 Aug 2020

Where did the copyright header go?

DIALIN-DEN-4211-1 28 Aug 2020

Where did the copyright header go?

DIALIN-DEN-4211-1 28 Aug 2020

Where id the copyright header go?

HD-DEN-5053-1 22 Sep 2020

Recommend moving doxygen commend to be right above or align the comment.

HD-DEN-4308-3 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 27 Aug 2020

Consider separating the two conditions here.

HD-DEN-4308-3 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 23 Sep 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4308-3 27 Aug 2020

Why not just use the state in the array of valve status directly?

HD-DEN-4308-3 27 Aug 2020

Where is valveData coming from?

HD-DEN-4308-3 02 Oct 2020

Removed this data publish.

UI-DEN-4964-1 13 Oct 2020

This should go under Models - HD - Data

UI-DEN-3605-4 05 Oct 2020

Done, will post update to the review soon

DIALIN-DEN-4211-1 28 Aug 2020

Why volumes are initialized to 0 (int) in some cases and to 0.0 (float) in other cases?

DG-DEN-5855-1 10 Dec 2020

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-4211-1 08 Sep 2020

This is an old formatted copyright. The new copyright format will be inserted into the file automatically by Bamboo.

UI-DEN-3605-4 05 Oct 2020

Done, will post update soon