Comment Search

Where did the copyright header go?

Done, see ad32b29

This file has been replaced with its Camel Case version.
But since it had a copyright change on server which had no code review assigned to it Crucible is showing it here after I merged master into my branch.
So actually this file doesn't exist anymore.

if ( targetDialInFlowRate == 0 )

No absolute values here. We can assume energized edge is higher than de-energized edge.

Why do you want absolute value of positions here? And if we do want absolute value, you should use abs(). fabs() is for floating point values.

Add two blank lines for separation from test support functions.

RESOLVED in CODE WALKTHROUGH.

Done

did

A parameter description is missing here

This class has been created as a template and guideline for later use.
Since it was renamed to not to be used in Coverage suggested, being removed.
So this file doesn't exist anymore.
But please look at it and use it as a template for sound settings implementation.
notice the Configuration namespace.

To allow toggling of print statements, replace prints with self.logger.debug("..."), self.logger.info("..."), self.logger.error("..."), etc..

Non-production code has been added to the manager home and settings screens. Should this reside on the production master branch?
Also, why is non-production code being unit tested?

Done.

Waiting until merge to staging - logger not yet available until then.

Please, align the variable names vertically to easier follow the code.

Same comment as above here.

RESOLVED

I have already merged master into the working branch, and resolved all merge conflicts

Should these files be renamed following our convention?

How come the renaming of files was done but the old files are not in red?

This file has been replaced with its Camel Case version.
But since it had a copyright change on server which had no code review assigned to it Crucible is showing it here after I merged master into my branch.
So actually this file doesn't exist anymore.

This file has been replaced with its Camel Case version.
But since it had a copyright change on server which had no code review assigned to it Crucible is showing it here after I merged master into my branch.
So actually this file doesn't exist anymore.

See the duplicate storageglobals.cpp on the left