messageinterpreter.cpp file in here shows "File Outdated" but not like the others have duplicate the latest. Please confirm that this file is what you meant it to be ...
Please don't use %0. It has not been documented in Qt, therefore the behavior is unpredicted. Also, it's always good to start from 1 in this case and I see no reason to do that?
I think Behrouz still uses that one. We need to be able to comment and uncomment as needed to achieve the desired build. Do not remove. For Bamboo and Vectorcast, none of these are seen so it has no impact on release builds or unit testing.
A test should be self-contained. QTest supposes to call this test function automatically. so what happens to the parameter obj? If this test needs an object it has to be created in the test function.
All the classes in this category have the naming structure of : Adjust<Name>RequestData , Why this class doesn't follow that convention? It hasn't been followed in AlarmSilenceRequestData as well, but it has Data at the end. Please follow the code structure.
When you say "the UI application can't safely quit the threads" is this something you think should be fixed?
If the UI quits itself will this and other similar methods be called? Shouldn't there be a test to ensure the UI can at least quit on its own properly?
When you run the code, the component could be positioned better. It should be moved left or up so there's no gap and so it's better aligned with either Tmprtr or Prsr Oc.
I'm seeing these '{" on new line like this sometimes and at end of line above in some cases. Does our C++ coding standard call for one or the other or does it allow either?
I checked out to your story branch and this comment is not even there anymore. By the way, I think by now you know that it should be here to validate parameters with HD, right?
All the treatment parameter response types are unsigned int. I think you may be looking at the Create Treatment Request in the message lists, not the response. There are 18 parameters listed here. There are 18 parameters listed in Message Lists.xlsx. Going through each one, one by one:
The order of the parameters was requested to be changed after the sprint in which this particular implementation was done. That ordering of the parameters change has already been implemented in a newer story and branch which will be going through code review soon. Therefore, the order of the parameters you see here is reflective of the message lists as it existed at the time this story was being worked on.
