Comment Search

Added an elseif to check for this condition.

Done

Remove this test code or put it in a build switch.

RESOLVED.

They are actually still being used for the png icon height and width. I've renamed them accordingly

Removed but not showing up here.

Done

This message id is not being used.

Remove extra line.

Remove extra line.

RESOLVED in CODE WALKTHROUGH.

As per our conversation today, due to the design changes with MAbstract.h and MModel.h that were merged to master on Aug. 31st, the create treatment models will be updated to subclass these parent classes.
This work is going to be tracked in this ticket: http://dvm-linux02:8080/browse/DEN-4981

RESOLVED in CODE WALKTHROUGH.

This is supposed to be part of the code review of the actual code which has been tested, so it can be seen clearly what has been tested and to what extend.
Please add it to the code review of the implemented code.

Return type is not here but it's sometimes provided elsewhere (see frameFlags docstring)

Move 2 characters to the left to align with two first lines.

"change" instead of "chane", also replace "I'm" with "I am", basically no informal language in code comments, only formal language.

Please put "done" when the code is pushed.

Added

No copyright?

Where did the copyright header go?

As per our conversation today, due to the design changes with MAbstract.h and MModel.h that were merged to master on Aug. 31st, the create treatment models will be updated to subclass these parent classes.
This work is going to be tracked in this ticket: http://dvm-linux02:8080/browse/DEN-4981

The function has been moved upward in order defined in the header Comm.h.

Removed.

Waiting until merge to staging - logger not yet available until then.