•  

Comment Results

Review Name Created Custom Fields Content
UI-DEN-4690-1 08 Sep 2020

Function description?

UI-DEN-4690-1 08 Sep 2020

Function description?

UI-DEN-4690-1 08 Sep 2020

Why does file name end in ._?

UI-DEN-4690-1 08 Sep 2020

this file has been replaced by its Camel Case version.
don't know why it shows up here!

UI-DEN-4690-1 08 Sep 2020

this file has been removed.
don't know why it shows up here!

UI-DEN-4690-1 08 Sep 2020

This file is removed with its Camel Case name version.

UI-DEN-4690-1 08 Sep 2020

Remove extra line.

HD-DEN-4308-3 22 Sep 2020

Done

HD-DEN-4308-3 27 Aug 2020

Retries?

HD-DEN-4308-3 27 Aug 2020

Global public data is a no-no. Just pass one off these into broadcast function call.

HD-DEN-4308-3 27 Aug 2020

I don't see any params in this function.

DIALIN-2 08 Sep 2020

Why this code review starts with "UI_" it's all Dialin.
Shouldn't it be started with Dialin?

HD-DEN-4211-1 26 Aug 2020

Remove function name from @brief and rename function name to match.

HD-DEN-4211-1 26 Aug 2020

Add blank line between two functions.

HD-DEN-4211-1 26 Aug 2020

Add doxygen header for below functions.

HD-DEN-4211-1 26 Aug 2020

Replace # with number.

DG-DEN-4322-1 26 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4211-1 26 Aug 2020

Suggest removing -1 and change to less than "<".

DG-DEN-4322-1 26 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-4322-1 25 Aug 2020

Were these not used anywhere? Even if not, seems like it may be in future (or should already be, but other drivers are defining their own). I recommend keeping these.

HD-DEN-4211-1 26 Aug 2020

Suggest removing -1 and change to less than "<".

DG-DEN-4322-1 26 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4211-1 26 Aug 2020

Is this an intent extra space between "data." and "A"?

DG-DEN-4322-1 26 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4211-1 26 Aug 2020

Replace # with number.

DG-DEN-4322-1 26 Aug 2020

RESOLVED in CODE WALKTHROUGH.

HD-DEN-4211-1 26 Aug 2020

Replace # with number.

DG-DEN-4322-1 26 Aug 2020

This has been fixed in Sprint26.

HD-DEN-4211-1 26 Aug 2020

Align doxygen comments.

DG-DEN-4322-1 26 Aug 2020

RESOLVED in CODE WALKTHROUGH.

DG-DEN-5855-1 10 Dec 2020

Suggest combining into one line since there is no other use for variable isFlowOutOfRange.

HD-DEN-5053-1 01 Oct 2020

Done.

DIALIN-DEN-4344-1 26 Aug 2020

Have you checked with Dara on this? I think the VM's are setup with the "~/projects" directory. Systems and V&V both have v4 of those VM's already...

HD-DEN-4211-1 26 Aug 2020

Remove function name.

HD-DEN-4211-1 26 Aug 2020

Missing one slash /.

DIALIN-DEN-4344-1 26 Aug 2020

I had the same thought awhile ago and begin investigating it. It may be possible - but will take some time. I previously created a Jira ticket to make sure we implement this feature in the future: http://dvm-linux02:8080/browse/DIAL-23.

DIALIN-DEN-4344-1 26 Aug 2020

I had the same thought awhile ago and begin investigating it. It may be possible - but will take some time. I previously created a Jira ticket to make sure we implement this feature in the future: http://dvm-linux02:8080/browse/DIAL-23.

HD-DEN-4211-1 26 Aug 2020

Change to doxygen style.

HD-DEN-4211-1 26 Aug 2020

Replace # with number.

HD-DEN-4211-1 26 Aug 2020

Change to doxygen style.

HD-DEN-4211-1 26 Aug 2020

Remove function name.

HD-DEN-4211-1 26 Aug 2020

Remove function name.

HD-DEN-4211-1 26 Aug 2020

Remove function name.

HD-DEN-4211-1 26 Aug 2020

Suggest removing -1 and change to less than "<".

HD-DEN-4211-1 26 Aug 2020

Change to doxygen style and remove function name.

HD-DEN-4211-1 26 Aug 2020

Change to doxygen style and remove function name.

DIALIN-DEN-4344-1 26 Aug 2020

great,
RESOLVED

DIALIN-DEN-4344-1 26 Aug 2020

Great,
RESOLVED

DIALIN-DEN-4344-1 26 Aug 2020

Yes I told him to update that.
Will remind him again.

HD-DEN-4211-1 26 Aug 2020

Do we want to expand all these macros?