Fixed. Module Pressure should use these definitions rather than defining its own.
Done.
Changed the file name so Doxygen is not documenting it. Doxygen is looking for .h/.cpp/.qml only.
Insert blank line between declarations and function code.
Please remove these since these are not used anymore.
Removed.
1. SIEMENS_TO_MICROSIEMENS_CONVERSION (Ss are missing) 2. Siemens (not Siemen) to microSiemens
Done
RESOLVED
Change private to public.
Remove function name.
Remove extra lines.
Why does file name end in ._?
Remove extra line.
RESOLVED.
Alarm ID 77 is being repeated. Change to 78.
RESOLVED in CODE WALKTHROUGH.
Suggesting move result assignment out since the result is same for all cases.
Confirmed. I think the latest changes to this file were part of the merge from master to this branch. I excluded the merge commits when creating this review after the request to remove merge commits from the old review: http://dvm-linux02:8060/cru/UI-DEN-3605-3#general-comments
Please remove them all. Always a good practice to keep only used/compiled/linked/built code in the repo.
Remove.
this file has been replaced by its Camel Case version. don't know why it shows up here!
Removed but not showing up here.
Same here
This file is removed with its Camel Case name version.
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
