Absolutely, I'm doing it incrementally and slowly to not to make the code reviews harder and confusing git. I did for so many and this file will get its turn soon.
Absolutely, I'm doing it incrementally and slowly to not to make the code reviews harder and confusing git. I did for so many and this file will get its turn soon.
I have a screen capture that I can't attach here and put in X:\Users\PemanM. As I explained in the image file, I don't quit understand how Squish is managing the last line. Now I removed extra it shows no empty line at the EOF but I see there is one, prior to that it was showing one but was actually two. Squish and Jira have different view. external editor is showing one empty line though.
This code review was created on August 25. The design changes with MAbstract and MModel were merged to master on August 31st. Our process now discourages merging code between development branches, so the create treatment implementation doesn't incorporate the design changes that were first merged to master on August 31st. As per our convesation yesterday, the work to subclass MAbstract and MModel, which will change the lines you're asking about, is going to be tracked in this ticket next sprint. http://dvm-linux02:8080/browse/DEN-4981
As per our conversation today, due to the design changes with MAbstract.h and MModel.h that were merged to master on Aug. 31st, the create treatment models will be updated to subclass these parent classes. This work is going to be tracked in this ticket: http://dvm-linux02:8080/browse/DEN-4981
I think we should cap all of these target position assignments. 15,000 counts is intended to over-reach commanded position. So just blindly adding/subtracting 15,000 from current position is not what we want. If current position +/- the big step is beyond our commanded position, we just want to set our target to the commanded position. Only if target is less than commanded position do we want to take the entire step.
"*** Off the subject ***" AGAIN, I don't understand what is the relevance of the comment to the Story and which part of the code this comment is referring to?
Absolutely, I'm doing it incrementally and slowly to not to make the code reviews harder and confusing git. I did for so many and this file will get its turn soon.
Absolutely, I'm doing it incrementally and slowly to not to make the code reviews harder and confusing git. I did for so many and this file will get its turn soon.
